You and I generally agree on style preferences... I think the warning
should be limited to grep ;$.
I did a grep on the kernel for ' ;' and found 8000 results. 6000 of
them are caught by my semicolon before the newline rule. The remaining
2000 are assembly, macros, and crappy for loops.
On Wed, 2013-12-04 at 10:38 +0300, Dan Carpenter wrote:
On Wed, Dec 04, 2013 at 06:35:15AM +0200, Aldo Iljazi wrote:
Samuel Thibault wrote:
Err, I'd rather make it really visible that the for loop doesn't have
its first statement?
Wouldn't it be better if you add a comment there?
Line 468: Removed a space before a semicolon.
Signed-off-by: Aldo Iljazi m...@aldo.io
---
drivers/staging/speakup/synth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c
index 0b3549b..2a4b348 100644
---
Aldo Iljazi, le Tue 03 Dec 2013 22:08:03 +0200, a écrit :
Line 468: Removed a space before a semicolon.
Err, I'd rather make it really visible that the for loop doesn't have
its first statement?
Samuel
___
devel mailing list
Samuel Thibault wrote:
Err, I'd rather make it really visible that the for loop doesn't have
its first statement?
Wouldn't it be better if you add a comment there? So it would follow the
coding style?
--
Aldo Iljazi
___
devel mailing list
On Wed, Dec 04, 2013 at 06:35:15AM +0200, Aldo Iljazi wrote:
Samuel Thibault wrote:
Err, I'd rather make it really visible that the for loop doesn't have
its first statement?
Wouldn't it be better if you add a comment there? So it would follow the
coding style?
No. Adding obvious
