Re: [PATCH] Staging: vt6655: Replace a camel case variable name

2021-02-10 Thread Greg Kroah-Hartman
On Thu, Feb 11, 2021 at 12:16:45PM +0530, Aakash Hemadri wrote: > On 21/02/10 06:50PM, Greg Kroah-Hartman wrote: > > On Wed, Feb 10, 2021 at 06:42:07PM +0800, Yujia Qiao wrote: > > > Replace camel case variable names with snake case in baseband.c. > > > > > > Signed-off-by: Yujia Qiao > > > --- >

Re: [PATCH] Staging: vt6655: Replace a camel case variable name

2021-02-10 Thread Yujia Qiao
On Thursday, 11 February 2021 14:46:45 CST Aakash Hemadri wrote: > When I first encountered the CamelCase check I believed that > making such changes would only cause trouble for others. > > Are such changes to API welcome in the kernel? I think it's not about changing the API here. A static

Re: [PATCH] Staging: vt6655: Replace a camel case variable name

2021-02-10 Thread Aakash Hemadri
On 21/02/10 06:50PM, Greg Kroah-Hartman wrote: > On Wed, Feb 10, 2021 at 06:42:07PM +0800, Yujia Qiao wrote: > > Replace camel case variable names with snake case in baseband.c. > > > > Signed-off-by: Yujia Qiao > > --- > > drivers/staging/vt6655/baseband.c | 4 ++-- > > 1 file changed, 2

[PATCH] Staging: vt6655: Replace a camel case variable name

2021-02-10 Thread Yujia Qiao
Replace camel case variable names with snake case in baseband.c. Signed-off-by: Yujia Qiao --- So I screwed up last two emails too. One with no subject and one with the wrong commit message. This times...I hope it's the last email for this patch. Sorry for the bother again.

Re: [PATCH] Staging: vt6655: Replace a camel case variable name

2021-02-10 Thread Greg Kroah-Hartman
On Wed, Feb 10, 2021 at 06:42:07PM +0800, Yujia Qiao wrote: > Replace camel case variable names with snake case in baseband.c. > > Signed-off-by: Yujia Qiao > --- > drivers/staging/vt6655/baseband.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) This doesn't apply cleanly to my

[PATCH] Staging: vt6655: Replace a camel case variable name

2021-02-10 Thread Yujia Qiao
Replace camel case variable names with snake case in baseband.c. Signed-off-by: Yujia Qiao --- drivers/staging/vt6655/baseband.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/ baseband.c index