Re: [PATCH] drivers/staging/wilc1000: fix sparse warning: right shift by bigger than source value

On Wed, 2017-07-12 at 08:12 +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 12, 2017 at 10:23:02AM +0800, Rui Teng wrote: > > On 12/07/2017 1:04 AM, Greg Kroah-Hartman wrote: > > > On Mon, Jul 10, 2017 at 04:57:31PM +0800, Rui Teng wrote: > > > > This patch sets memory to zero directly to avoid

Re: [PATCH] drivers/staging/wilc1000: fix sparse warning: right shift by bigger than source value

On Wed, Jul 12, 2017 at 10:23:02AM +0800, Rui Teng wrote: > On 12/07/2017 1:04 AM, Greg Kroah-Hartman wrote: > > On Mon, Jul 10, 2017 at 04:57:31PM +0800, Rui Teng wrote: > > > This patch sets memory to zero directly to avoid unnecessary shift and > > > bitwise operations on bool type, which can

Re: [PATCH] drivers/staging/wilc1000: fix sparse warning: right shift by bigger than source value

On 12/07/2017 1:04 AM, Greg Kroah-Hartman wrote: On Mon, Jul 10, 2017 at 04:57:31PM +0800, Rui Teng wrote: This patch sets memory to zero directly to avoid unnecessary shift and bitwise operations on bool type, which can fix a sparse warning and also improve performance. It does? How did you

Re: [PATCH] drivers/staging/wilc1000: fix sparse warning: right shift by bigger than source value

On Mon, Jul 10, 2017 at 04:57:31PM +0800, Rui Teng wrote: > This patch sets memory to zero directly to avoid unnecessary shift and > bitwise operations on bool type, which can fix a sparse warning and also > improve performance. It does? How did you measure the performance impact? What was now

[PATCH] drivers/staging/wilc1000: fix sparse warning: right shift by bigger than source value

This patch sets memory to zero directly to avoid unnecessary shift and bitwise operations on bool type, which can fix a sparse warning and also improve performance. Signed-off-by: Rui Teng --- drivers/staging/wilc1000/host_interface.c | 7 +++ 1 file changed, 3