Re: [PATCH] erofs: Use common kernel logging style

Hi Joe, On Sun, Aug 18, 2019 at 10:47:17PM -0700, Joe Perches wrote: > On Mon, 2019-08-19 at 13:52 +0800, Gao Xiang wrote: > > Hi Joe, > > Hello. > > > On Sun, Aug 18, 2019 at 10:28:41PM -0700, Joe Perches wrote: > > > Rename errln, infoln, and debugln to the typical pr_ uses > > > to the

Re: [PATCH] erofs: Use common kernel logging style

On Mon, 2019-08-19 at 13:52 +0800, Gao Xiang wrote: > Hi Joe, Hello. > On Sun, Aug 18, 2019 at 10:28:41PM -0700, Joe Perches wrote: > > Rename errln, infoln, and debugln to the typical pr_ uses > > to the typical kernel styles of pr_ > > How about using erofs_err / ... to instead that? I've

[PATCH] erofs: Use common kernel logging style

Rename errln, infoln, and debugln to the typical pr_ uses to the typical kernel styles of pr_ Miscellanea: o Add newline terminations to the uses o Use "%s: ...", __func__ and not the atypical "%s, ...", __func__ o Trivial grammar changes in output logging o Delete the now unused macros

Re: [PATCH] erofs: Use common kernel logging style

Hi Joe, On Sun, Aug 18, 2019 at 10:28:41PM -0700, Joe Perches wrote: > Rename errln, infoln, and debugln to the typical pr_ uses > to the typical kernel styles of pr_ How about using erofs_err / ... to instead that? - I can hardly see directly use pr_ for those filesystems in fs/... - maybe