Re: [PATCH] media: staging/imx: add media device to capture register

2019-04-28 Thread Rui Miguel Silva
Hi Steve, On Sun 28 Apr 2019 at 19:53, Steve Longerbeam wrote: > Hi Rui, > > On second thought, there is no reason to pass the media device to > imx_media_capture_device_register(), because it is already available via > v4l2_dev->mdev. I will be posting a patch in v2 of the "Switch to sync >

Re: [PATCH] media: staging/imx: add media device to capture register

2019-04-28 Thread Steve Longerbeam
Hi Rui, On second thought, there is no reason to pass the media device to imx_media_capture_device_register(), because it is already available via v4l2_dev->mdev. I will be posting a patch in v2 of the "Switch to sync registration for IPU subdevs" series that fixes this. Steve On 4/12/19

Re: [PATCH] media: staging/imx: add media device to capture register

2019-04-18 Thread Steve Longerbeam
Acked-by: Steve Longerbeam On 4/12/19 9:44 AM, Rui Miguel Silva wrote: When register the capture media device it is assumed that the device data is the media device. In the imx6 case is but in the imx7 is not case. The device data is the csi structure. Add the explicit argument of the media

Re: [PATCH] media: staging/imx: add media device to capture register

2019-04-18 Thread Laurent Pinchart
Hi Rui, Thank you for the patch. On Fri, Apr 12, 2019 at 05:44:00PM +0100, Rui Miguel Silva wrote: > When register the capture media device it is assumed that the device > data is the media device. In the imx6 case is but in the imx7 is not > case. The device data is the csi structure. > > Add

[PATCH] media: staging/imx: add media device to capture register

2019-04-12 Thread Rui Miguel Silva
When register the capture media device it is assumed that the device data is the media device. In the imx6 case is but in the imx7 is not case. The device data is the csi structure. Add the explicit argument of the media device that we want to associate with the capture device. Reported-by: