RE: [PATCH] media: staging/intel-ipu3: Implement lock for stream on/off operations

2019-02-04 Thread Mani, Rajmohan
Hi Sakari, [snip] > > > > > fail_stop_pipeline: > > > > > @@ -543,6 +546,8 @@ static void ipu3_vb2_stop_streaming(struct > > > > vb2_queue *vq) > > > > > dev_err(>pci_dev->dev, > > > > > "failed to stop subdev streaming\n"); > > > > > > > > > > +

RE: [PATCH] media: staging/intel-ipu3: Implement lock for stream on/off operations

2019-02-01 Thread Mani, Rajmohan
Hi Sakari, > Subject: Re: [PATCH] media: staging/intel-ipu3: Implement lock for stream > on/off operations > > Hi Raj, > > On Wed, Jan 30, 2019 at 05:17:15PM +, Mani, Rajmohan wrote: > > Hi Sakari, > > > > > -Original Message- >

Re: [PATCH] media: staging/intel-ipu3: Implement lock for stream on/off operations

2019-02-01 Thread Sakari Ailus
; hverk...@xs4all.nl; tf...@chromium.org > > Subject: Re: [PATCH] media: staging/intel-ipu3: Implement lock for stream > > on/off operations > > > > Hi Rajmohan, > > > > On Tue, Jan 29, 2019 at 02:27:36PM -0800, Rajmohan Mani wrote: > > > Currently concurrent

Re: [PATCH] media: staging/intel-ipu3: Implement lock for stream on/off operations

2019-01-31 Thread Sakari Ailus
; hverk...@xs4all.nl; tf...@chromium.org > > Subject: Re: [PATCH] media: staging/intel-ipu3: Implement lock for stream > > on/off operations > > > > Hi Rajmohan, > > > > On Tue, Jan 29, 2019 at 02:27:36PM -0800, Rajmohan Mani wrote: > > > Currently concurrent

RE: [PATCH] media: staging/intel-ipu3: Implement lock for stream on/off operations

2019-01-30 Thread Mani, Rajmohan
osuosl.org; linux-ker...@vger.kernel.org; Laurent Pinchart > ; Jacopo Mondi ; > Qiu, Tian Shu ; Cao, Bingbu > ; z...@paasikivi.fi.intel.com; Zhi, Yong > ; hverk...@xs4all.nl; tf...@chromium.org > Subject: Re: [PATCH] media: staging/intel-ipu3: Implement lock for stream > on/off operation

Re: [PATCH] media: staging/intel-ipu3: Implement lock for stream on/off operations

2019-01-30 Thread Sakari Ailus
Hi Rajmohan, On Tue, Jan 29, 2019 at 02:27:36PM -0800, Rajmohan Mani wrote: > Currently concurrent stream off operations on ImgU nodes are not > synchronized, leading to use-after-free bugs (as reported by KASAN). > > [ 250.090724] BUG: KASAN: use-after-free in ipu3_dmamap_free+0xc5/0x116 >

[PATCH] media: staging/intel-ipu3: Implement lock for stream on/off operations

2019-01-29 Thread Rajmohan Mani
Currently concurrent stream off operations on ImgU nodes are not synchronized, leading to use-after-free bugs (as reported by KASAN). [ 250.090724] BUG: KASAN: use-after-free in ipu3_dmamap_free+0xc5/0x116 [ipu3_imgu] [ 250.090726] Read of size 8 at addr 888127b29bc0 by task yavta/18836 [