Re: [PATCH] media: staging: omap4iss: Include asm/cacheflush.h after generic includes

2018-07-24 Thread Linus Torvalds
On Tue, Jul 24, 2018 at 11:39 AM Mauro Carvalho Chehab wrote: > > Works for me. Do you intend to apply it directly? Yes, I took it and it should be pushed out. > Yeah, some time ago mailing lists got flooded with some janitorial's > patchset adding includes (some claiming to be needed on some

Re: [PATCH] media: staging: omap4iss: Include asm/cacheflush.h after generic includes

2018-07-24 Thread Mauro Carvalho Chehab
Em Tue, 24 Jul 2018 10:37:56 -0700 Linus Torvalds escreveu: > On Mon, Jul 23, 2018 at 8:41 PM Mauro Carvalho Chehab > wrote: > > > > While I won't be against merging it, IMHO a better fix would be to > > add the includes asm/cacheflush.h needs inside it, e. g. something > > like adding: > >

Re: [PATCH] media: staging: omap4iss: Include asm/cacheflush.h after generic includes

2018-07-24 Thread Linus Torvalds
On Mon, Jul 23, 2018 at 8:41 PM Mauro Carvalho Chehab wrote: > > While I won't be against merging it, IMHO a better fix would be to > add the includes asm/cacheflush.h needs inside it, e. g. something > like adding: No. The includes really should come after . This is a media driver bug, plain

Re: [PATCH] media: staging: omap4iss: Include asm/cacheflush.h after generic includes

2018-07-23 Thread Mauro Carvalho Chehab
Em Mon, 23 Jul 2018 14:39:33 -0700 Guenter Roeck escreveu: > Including asm/cacheflush.h first results in the following build error when > trying to build sparc32:allmodconfig. > > In file included from arch/sparc/include/asm/page.h:10:0, > from

Re: [PATCH] media: staging: omap4iss: Include asm/cacheflush.h after generic includes

2018-07-23 Thread David Miller
From: Guenter Roeck Date: Mon, 23 Jul 2018 14:39:33 -0700 > Including asm/cacheflush.h first results in the following build error when > trying to build sparc32:allmodconfig. ... > Include generic includes files first to fix the problem. > > Fixes: fc96d58c10162 ("[media] v4l: omap4iss: Add

[PATCH] media: staging: omap4iss: Include asm/cacheflush.h after generic includes

2018-07-23 Thread Guenter Roeck
Including asm/cacheflush.h first results in the following build error when trying to build sparc32:allmodconfig. In file included from arch/sparc/include/asm/page.h:10:0, from arch/sparc/include/asm/string_32.h:13, from arch/sparc/include/asm/string.h:7,