Re: [PATCH] mmc: rtsx: usb backend needs LED support

2014-05-08 Thread Ulf Hansson
>>> >>> From: Roger Tseng >>> Date: Wed, 30 Apr 2014 11:11:25 +0800 >>> Subject: [PATCH] mmc: rtsx: fix possible linking error if built-in >>> >>> rtsx_usb_sdmmc module uses the LED classdev if available, but the code >>> failed >>> to consider the situation that it is built-in and the LED classde

Re: [PATCH] mmc: rtsx: usb backend needs LED support

2014-05-08 Thread Lee Jones
> >>From: Roger Tseng > >>Date: Wed, 30 Apr 2014 11:11:25 +0800 > >>Subject: [PATCH] mmc: rtsx: fix possible linking error if built-in > >> > >>rtsx_usb_sdmmc module uses the LED classdev if available, but the code > >>failed > >>to consider the situation that it is built-in and the LED classdev i

Re: [PATCH] mmc: rtsx: usb backend needs LED support

2014-05-08 Thread Arnd Bergmann
On Thursday 08 May 2014 16:08:15 Roger wrote: > > Would this patch be merged into linux-next or Lee's mfd.git > ib-mfd-mmc-memstick-3.16 branch? It should get merged into whatever tree holds the existing patches, yes > By the way, should I resend my version? Actually I found another issue with

Re: [PATCH] mmc: rtsx: usb backend needs LED support

2014-05-08 Thread Roger
7 00:00:00 2001 From: Arnd Bergmann Date: Tue, 29 Apr 2014 11:41:40 +0200 Subject: [PATCH] mmc: rtsx: usb backend needs LED support Building the rtsx USB driver uses the LED classdev base support if available, but that fails if the classdev is a module and the MMC driver is built-in, leading

Re: [PATCH] mmc: rtsx: usb backend needs LED support

2014-04-30 Thread Ulf Hansson
se >>> leds, apparently that's not working properly. >>> >> >> Ah, right, I misinterpreted the bug. Here is a new version: >> >> 8<- >>> >>> From 5b5588f8c9b8ded8b296fd32d87b2d118e548a29 Mon Sep 17 00:00:00 2001 >> &g

Re: [PATCH] mmc: rtsx: usb backend needs LED support

2014-04-30 Thread Arnd Bergmann
On Wednesday 30 April 2014 11:34:33 Roger wrote: > I think Ulf's idea is to fix the bug by modifying the .c files. > I really found the problem of my ifdef hackery and it should do > something similar in sdhci.c as: > > From: Roger Tseng > Date: Wed, 30 Apr 2014 11:11:25 +0800 > Subject: [PATCH]

Re: [PATCH] mmc: rtsx: usb backend needs LED support

2014-04-29 Thread Roger
aking it optional to use leds, apparently that's not working properly. Ah, right, I misinterpreted the bug. Here is a new version: 8<- From 5b5588f8c9b8ded8b296fd32d87b2d118e548a29 Mon Sep 17 00:00:00 2001 From: Arnd Bergmann Date: Tue, 29 Apr 2014 11:41:40 +0200 Subject: [P

Re: [PATCH] mmc: rtsx: usb backend needs LED support

2014-04-29 Thread Arnd Bergmann
There are already some ifdefs hackery for making it optional to use > leds, apparently that's not working properly. > Ah, right, I misinterpreted the bug. Here is a new version: 8<- >From 5b5588f8c9b8ded8b296fd32d87b2d118e548a29 Mon Sep 17 00:00:00 2001 From: Arnd Bergma

Re: [PATCH] mmc: rtsx: usb backend needs LED support

2014-04-29 Thread Ulf Hansson
01 > From: Arnd Bergmann > Date: Tue, 29 Apr 2014 11:41:40 +0200 > Subject: [PATCH] mmc: rtsx: usb backend needs LED support > > Building the rtsx USB driver requires the LED classdev base > support, otherwise we get this build error: > > drivers/built-in.o: In function

[PATCH] mmc: rtsx: usb backend needs LED support

2014-04-29 Thread Arnd Bergmann
H] mmc: rtsx: usb backend needs LED support Building the rtsx USB driver requires the LED classdev base support, otherwise we get this build error: drivers/built-in.o: In function `rtsx_usb_sdmmc_drv_remove': :(.text+0x806480): undefined reference to `led_classdev_unregister' driver