Re: [PATCH] netvsc: fix dereference before null check errors

2017-03-27 Thread David Miller
microsoft.com>; Haiyang Zhang >> <haiya...@microsoft.com>; Stephen Hemminger <sthem...@microsoft.com>; >> de...@linuxdriverproject.org; net...@vger.kernel.org >> Cc: kernel-janit...@vger.kernel.org; linux-ker...@vger.kernel.org >> Subject: [PATCH] netvsc: fix dereference

RE: [PATCH] netvsc: fix dereference before null check errors

2017-03-26 Thread Haiyang Zhang
t; de...@linuxdriverproject.org; net...@vger.kernel.org > Cc: kernel-janit...@vger.kernel.org; linux-ker...@vger.kernel.org > Subject: [PATCH] netvsc: fix dereference before null check errors > > From: Colin Ian King <colin.k...@canonical.com> > > ndev is being checked to see

[PATCH] netvsc: fix dereference before null check errors

2017-03-25 Thread Colin King
From: Colin Ian King ndev is being checked to see if it is a null pointer however before the null check ndev is being dereferenced; hence there is a potential null pointer dereference bug that needs fixing. Fix this by only dereferencing ndev after the null check.