Re: [PATCH] staging/rdma/hfi1: Reduce number of parameters passed to send handlers

2015-11-12 Thread Dennis Dalessandro
On Thu, Nov 12, 2015 at 08:04:01AM +0200, Or Gerlitz wrote: On Wed, Nov 11, 2015 at 3:39 PM, Dennis Dalessandro wrote: On Wed, Nov 11, 2015 at 08:25:35AM +0200, Leon Romanovsky wrote: On Wed, Nov 11, 2015 at 12:34:37AM -0500, ira.we...@intel.com wrote: From:

Re: [PATCH] staging/rdma/hfi1: Reduce number of parameters passed to send handlers

2015-11-12 Thread Or Gerlitz
On Thu, Nov 12, 2015 at 3:25 PM, Dennis Dalessandro wrote: > On Thu, Nov 12, 2015 at 08:04:01AM +0200, Or Gerlitz wrote: >> Dennis, can we have less camelcase sort of speak in this upstream driver? >> this is linux here not windowZ. > I plan to just remove this

Re: [PATCH] staging/rdma/hfi1: Reduce number of parameters passed to send handlers

2015-11-11 Thread Dennis Dalessandro
On Wed, Nov 11, 2015 at 08:25:35AM +0200, Leon Romanovsky wrote: On Wed, Nov 11, 2015 at 12:34:37AM -0500, ira.we...@intel.com wrote: From: Dennis Dalessandro +int snoop_send_dma_handler(struct hfi1_qp *qp, struct hfi1_pkt_state *ps, +

Re: [PATCH] staging/rdma/hfi1: Reduce number of parameters passed to send handlers

2015-11-11 Thread Leon Romanovsky
On Wed, Nov 11, 2015 at 08:39:08AM -0500, Dennis Dalessandro wrote: > On Wed, Nov 11, 2015 at 08:25:35AM +0200, Leon Romanovsky wrote: > >On Wed, Nov 11, 2015 at 12:34:37AM -0500, ira.we...@intel.com wrote: > >>From: Dennis Dalessandro > >> > >>+int

Re: [PATCH] staging/rdma/hfi1: Reduce number of parameters passed to send handlers

2015-11-11 Thread Or Gerlitz
On Wed, Nov 11, 2015 at 3:39 PM, Dennis Dalessandro wrote: > On Wed, Nov 11, 2015 at 08:25:35AM +0200, Leon Romanovsky wrote: >> On Wed, Nov 11, 2015 at 12:34:37AM -0500, ira.we...@intel.com wrote: >>> From: Dennis Dalessandro >>> +int

Re: [PATCH] staging/rdma/hfi1: Reduce number of parameters passed to send handlers

2015-11-10 Thread Leon Romanovsky
On Wed, Nov 11, 2015 at 12:34:37AM -0500, ira.we...@intel.com wrote: > From: Dennis Dalessandro > > +int snoop_send_dma_handler(struct hfi1_qp *qp, struct hfi1_pkt_state *ps, > +u64 pbc) > { > - pr_alert("Snooping/Capture of Send DMA

[PATCH] staging/rdma/hfi1: Reduce number of parameters passed to send handlers

2015-11-10 Thread ira . weiny
From: Dennis Dalessandro The current send function handlers are passed a bunch of parameters that are already part of the data structure that is passed in first (qp). This patch removes all of this and just passes the QP. Reviewed-by: Mike Marciniszyn