It's possible for dev_alloc_skb() to fail. Propagate the error to the caller,
so it can clean up and drop the packet. The sender should end up retransmitting
the packet, hopefully at a time we're prepared to allocate skb's again.

Reported-By: Nicholas Krause <xerofo...@gmail.com>
Signed-Off-By: Valdis Kletnieks <valdis.kletni...@vt.edu>

--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c 2014-09-05 
15:51:00.005660044 -0400
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c 2014-09-08 
17:42:16.773748142 -0400
@@ -847,6 +847,8 @@ static u8 parse_subframe(struct sk_buff
 #else
                        /* Allocate new skb for releasing to upper layer */
                        sub_skb = dev_alloc_skb(nSubframe_Length + 12);
+                       if (!sub_skb)
+                               return 0;
                        skb_reserve(sub_skb, 12);
                        data_ptr = (u8 *)skb_put(sub_skb, nSubframe_Length);
                        memcpy(data_ptr, skb->data, nSubframe_Length);


_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to