Re: [PATCH] staging: android: ashmem: used const keyword

2020-08-05 Thread kernel test robot
Hi Dhiraj, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Dhiraj-Sharma/staging-android-ashmem-used-const-keyword/20200729-020222 base:

Re: [PATCH] staging: android: ashmem: used const keyword

2020-07-29 Thread kernel test robot
Hi Dhiraj, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Dhiraj-Sharma/staging-android-ashmem-used-const-keyword/20200729-020222 base:

Re: [PATCH] staging: android: ashmem: used const keyword

2020-07-29 Thread kernel test robot
Hi Dhiraj, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Dhiraj-Sharma/staging-android-ashmem-used-const-keyword/20200729-020222 base:

Re: [PATCH] staging: android: ashmem: used const keyword

2020-07-28 Thread Joe Perches
On Tue, 2020-07-28 at 23:29 +0530, Dhiraj Sharma wrote: > I ran checkpatch.pl script which reported a warning to use const keyword > on line 370.Therefore I made this change. checkpatch is a brainless script. Not everything it suggests is appropriate. > diff --git

Re: [PATCH] staging: android: ashmem: used const keyword

2020-07-28 Thread Dhiraj Sharma
Alright, I have understood now that I should not trust on checkpatch.pl script fully but partially it is indeed helpful. Please don't criticize this script, it was my fault instead. Before submitting code changes I would test them all, sorry for wasting your time please ignore this patch changes

Re: [PATCH] staging: android: ashmem: used const keyword

2020-07-28 Thread Greg KH
On Tue, Jul 28, 2020 at 11:29:35PM +0530, Dhiraj Sharma wrote: > I ran checkpatch.pl script which reported a warning to use const keyword > on line 370.Therefore I made this change. > > Signed-off-by: Dhiraj Sharma > --- > drivers/staging/android/ashmem.c | 2 +- > 1 file changed, 1

[PATCH] staging: android: ashmem: used const keyword

2020-07-28 Thread Dhiraj Sharma
I ran checkpatch.pl script which reported a warning to use const keyword on line 370.Therefore I made this change. Signed-off-by: Dhiraj Sharma --- drivers/staging/android/ashmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ashmem.c