Re: [RESEND PATCH] staging: bcm2835-audio: Disconnect and free vchi_instance on module_exit()

On Tue, Apr 24, 2018 at 08:51:34PM +0200, Kirill Marinushkin wrote: > On 04/24/18 20:35, Andy Shevchenko wrote: > > On Tue, Apr 24, 2018 at 9:27 PM, Kirill Marinushkin > > wrote: > > > >> @Andy > >> > >>> AFAIR I gave you a tag and you again missed it. > >>> Before

Re: [RESEND PATCH] staging: bcm2835-audio: Disconnect and free vchi_instance on module_exit()

On 04/24/18 20:35, Andy Shevchenko wrote: > On Tue, Apr 24, 2018 at 9:27 PM, Kirill Marinushkin > wrote: > >> @Andy >> >>> AFAIR I gave you a tag and you again missed it. >>> Before sending anything just check twice if all prerequisites are fulfilled. >> I think you mix

Re: [RESEND PATCH] staging: bcm2835-audio: Disconnect and free vchi_instance on module_exit()

On Tue, Apr 24, 2018 at 9:27 PM, Kirill Marinushkin wrote: > @Andy > >> AFAIR I gave you a tag and you again missed it. >> Before sending anything just check twice if all prerequisites are fulfilled. > > I think you mix it up. This is a new patch, you didn't review it

Re: [RESEND PATCH] staging: bcm2835-audio: Disconnect and free vchi_instance on module_exit()

@Greg > I have no idea as the patch is long gone from my queue now. If you > think all is fine, please resend it and I will be glad to review it > again. Stefan, Dan and Andy explained me, what caused the compiler warning in my patch, and why I couldn't reproduce it. I will fix the root cause,

Re: [RESEND PATCH] staging: bcm2835-audio: Disconnect and free vchi_instance on module_exit()

On Tue, Apr 24, 2018 at 10:44 AM, Kirill Marinushkin wrote: > In the current implementation, vchi_instance is inited during the first > call of bcm2835_audio_open_connection(), and is never freed. It causes a > memory leak when the module `snd_bcm2835` is removed. >

Re: [RESEND PATCH] staging: bcm2835-audio: Disconnect and free vchi_instance on module_exit()

On Tue, Apr 24, 2018 at 09:44:59AM +0200, Kirill Marinushkin wrote: > In the current implementation, vchi_instance is inited during the first > call of bcm2835_audio_open_connection(), and is never freed. It causes a > memory leak when the module `snd_bcm2835` is removed. > > Here is how this

Re: [PATCH] staging: bcm2835-audio: Disconnect and free vchi_instance on module_exit()

Hi Kirill, Am 24.04.2018 um 02:35 schrieb Kirill Marinushkin: On 04/23/18 15:50, Greg Kroah-Hartman wrote: On Tue, Apr 17, 2018 at 07:00:28AM +0200, Kirill Marinushkin wrote: In the current implementation, vchi_instance is inited during the first call of bcm2835_audio_open_connection(), and

[RESEND PATCH] staging: bcm2835-audio: Disconnect and free vchi_instance on module_exit()

In the current implementation, vchi_instance is inited during the first call of bcm2835_audio_open_connection(), and is never freed. It causes a memory leak when the module `snd_bcm2835` is removed. Here is how this commit fixes it: * the VCHI context (including vchi_instance) is created once in

Re: [PATCH] staging: bcm2835-audio: Disconnect and free vchi_instance on module_exit()

On Tue, Apr 24, 2018 at 02:35:50AM +0200, Kirill Marinushkin wrote: > On 04/23/18 15:50, Greg Kroah-Hartman wrote: > > On Tue, Apr 17, 2018 at 07:00:28AM +0200, Kirill Marinushkin wrote: > >> In the current implementation, vchi_instance is inited during the first > >> call of

Re: [PATCH] staging: bcm2835-audio: Disconnect and free vchi_instance on module_exit()

On 04/23/18 15:50, Greg Kroah-Hartman wrote: > On Tue, Apr 17, 2018 at 07:00:28AM +0200, Kirill Marinushkin wrote: >> In the current implementation, vchi_instance is inited during the first >> call of bcm2835_audio_open_connection(), and is never freed. It causes a >> memory leak when the module

Re: [PATCH] staging: bcm2835-audio: Disconnect and free vchi_instance on module_exit()

On Tue, Apr 17, 2018 at 07:00:28AM +0200, Kirill Marinushkin wrote: > In the current implementation, vchi_instance is inited during the first > call of bcm2835_audio_open_connection(), and is never freed. It causes a > memory leak when the module `snd_bcm2835` is removed. > > Here is how this

Re: [PATCH] staging: bcm2835-audio: Disconnect and free vchi_instance on module_exit()

Hi Kirill, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] [also build test WARNING on v4.17-rc1] [cannot apply to anholt/for-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

[PATCH] staging: bcm2835-audio: Disconnect and free vchi_instance on module_exit()

In the current implementation, vchi_instance is inited during the first call of bcm2835_audio_open_connection(), and is never freed. It causes a memory leak when the module `snd_bcm2835` is removed. Here is how this commit fixes it: * the VCHI context (including vchi_instance) is created once in