Re: [PATCH] staging: comedi: add error handling for vmap

2018-06-14 Thread Ian Abbott
On 14/06/18 08:57, Zhouyang Jia wrote: Hi, I reported this bug since more than 90% callsites of vmap are well handled in kernel. The caller function __comedi_buf_alloc has no return value, so I don't know how the error is handled in its caller. I believe there would be a better error handling

Re: [PATCH] staging: comedi: add error handling for vmap

2018-06-12 Thread Dan Carpenter
On Tue, Jun 12, 2018 at 11:25:35AM +0800, Zhouyang Jia wrote: > When vmap fails, the lack of error-handling code may > cause unexpected results. > > This patch adds error-handling code after calling vmap. > Again, this is not error handling, this is just an error message. This error condition

[PATCH] staging: comedi: add error handling for vmap

2018-06-11 Thread Zhouyang Jia
When vmap fails, the lack of error-handling code may cause unexpected results. This patch adds error-handling code after calling vmap. Signed-off-by: Zhouyang Jia --- drivers/staging/comedi/comedi_buf.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git