Re: [PATCH] staging: dgap: fix smatch warn: missing break in case

2014-05-21 Thread Mark Hounschell
On 05/21/2014 03:59 PM, Dan Carpenter wrote: > On Wed, May 21, 2014 at 01:03:09PM -0400, Mark Hounschell wrote: >> This patch fixes an smatch warning about a missing break >> in a case statement. >> > > I would prefer if we leave the code as-is and fix Smatch. The fix will > be to read the previ

Re: [PATCH] staging: dgap: fix smatch warn: missing break in case

2014-05-21 Thread Dan Carpenter
On Wed, May 21, 2014 at 01:03:09PM -0400, Mark Hounschell wrote: > This patch fixes an smatch warning about a missing break > in a case statement. > I would prefer if we leave the code as-is and fix Smatch. The fix will be to read the previous line or two for the word "fall" so just moving the

[PATCH] staging: dgap: fix smatch warn: missing break in case

2014-05-21 Thread Mark Hounschell
This patch fixes an smatch warning about a missing break in a case statement. Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman Tested-by: Mark Hounschell --- drivers/staging/dgap/dgap.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/dgap/dgap.c