Re: [PATCH] staging: exfat: cleanup braces for if/else statements

2019-09-04 Thread Valentin Vidić
On Wed, Sep 04, 2019 at 09:38:55AM +, David Laight wrote: > From: Valentin Vidic > > Sent: 03 September 2019 19:12 > > On Tue, Sep 03, 2019 at 06:32:49PM +0100, Al Viro wrote: > > > On Tue, Sep 03, 2019 at 06:47:32PM +0200, Valentin Vidic wrote: > > > > + } else if (uni

RE: [PATCH] staging: exfat: cleanup braces for if/else statements

2019-09-04 Thread David Laight
From: Valentin Vidic > Sent: 03 September 2019 19:12 > On Tue, Sep 03, 2019 at 06:32:49PM +0100, Al Viro wrote: > > On Tue, Sep 03, 2019 at 06:47:32PM +0200, Valentin Vidic wrote: > > > + } else if (uni == 0x) { > > > skip = TRUE; > > > > While we are

Re: [PATCH] staging: exfat: cleanup braces for if/else statements

2019-09-03 Thread Greg Kroah-Hartman
On Tue, Sep 03, 2019 at 06:32:49PM +0100, Al Viro wrote: > On Tue, Sep 03, 2019 at 06:47:32PM +0200, Valentin Vidic wrote: > > + } else if (uni == 0x) { > > skip = TRUE; > > While we are at it, could you get rid of that 'TRUE' macro? > Or added >

Re: [PATCH] staging: exfat: cleanup braces for if/else statements

2019-09-03 Thread Valentin Vidić
On Tue, Sep 03, 2019 at 06:32:49PM +0100, Al Viro wrote: > On Tue, Sep 03, 2019 at 06:47:32PM +0200, Valentin Vidic wrote: > > + } else if (uni == 0x) { > > skip = TRUE; > > While we are at it, could you get rid of that 'TRUE' macro? Sure, but

Re: [PATCH] staging: exfat: cleanup braces for if/else statements

2019-09-03 Thread Al Viro
On Tue, Sep 03, 2019 at 06:47:32PM +0200, Valentin Vidic wrote: > + } else if (uni == 0x) { > skip = TRUE; While we are at it, could you get rid of that 'TRUE' macro? Or added #define THE_TRUTH_AND_THATS_CUTTIN_ME_OWN_THROAT true if you want

[PATCH] staging: exfat: cleanup braces for if/else statements

2019-09-03 Thread Valentin Vidic
Fixes checkpatch.pl warnings: CHECK: Unbalanced braces around else statement CHECK: braces {} should be used on all arms of this statement Signed-off-by: Valentin Vidic --- drivers/staging/exfat/exfat_core.c | 12 ++-- drivers/staging/exfat/exfat_super.c | 16 +--- 2