Re: [PATCH] staging: fbtft: Replace a bit shift by a use of BIT.

2017-03-22 Thread Andy Shevchenko
On Wed, Mar 22, 2017 at 6:18 PM, Andy Shevchenko wrote: > On Wed, Mar 22, 2017 at 4:37 AM, Arushi Singhal > wrote: >> This patch replaces bit shifting on 1 with the BIT(x) macro. >> This was done with coccinelle: >> @@ >> constant c; >>

Re: [PATCH] staging: fbtft: Replace a bit shift by a use of BIT.

2017-03-22 Thread Andy Shevchenko
On Wed, Mar 22, 2017 at 4:37 AM, Arushi Singhal wrote: > This patch replaces bit shifting on 1 with the BIT(x) macro. > This was done with coccinelle: > @@ > constant c; > @@ > > -1 << c > +BIT(c) > While using BIT() macro is a good idea, you make it inconsistent

[PATCH] staging: fbtft: Replace a bit shift by a use of BIT.

2017-03-21 Thread Arushi Singhal
This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal --- drivers/staging/fbtft/fb_agm1264k-fl.c | 4 ++-- drivers/staging/fbtft/fb_ili9163.c | 2 +-