Re: [PATCH] staging: gdm724x: gdm_tty: replaced macro with an inline function

2020-09-01 Thread kernel test robot
Hi Antoni, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Antoni-Przybylik/staging-gdm724x-gdm_tty-replaced-macro-with-an-inline-function/20200901-234632 base:

Re: [PATCH] staging: gdm724x: gdm_tty: replaced macro with an inline function

2020-09-01 Thread Greg KH
On Tue, Sep 01, 2020 at 05:44:37PM +0200, Antoni Przybylik wrote: > This approach is more elegant and prevents some problems related to > macros such as operator precedence in expanded expression. > > Signed-off-by: Antoni Przybylik > --- > drivers/staging/gdm724x/gdm_tty.c | 15

[PATCH] staging: gdm724x: gdm_tty: replaced macro with an inline function

2020-09-01 Thread Antoni Przybylik
This approach is more elegant and prevents some problems related to macros such as operator precedence in expanded expression. Signed-off-by: Antoni Przybylik --- drivers/staging/gdm724x/gdm_tty.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git