Re: [PATCH] staging: goldfish: switch from spinlock to mutex

2014-04-08 Thread Dan Carpenter
On Sat, Apr 05, 2014 at 05:38:05PM +0300, Kristina Martšenko wrote: > On 04/04/14 16:30, Dan Carpenter wrote: > > On Fri, Apr 04, 2014 at 02:46:14PM +0300, Kristina Martšenko wrote: > > > >> Yes, I didn't find any interrupt handlers either, which is partially why > >> I thought it was (probably) s

Re: [PATCH] staging: goldfish: switch from spinlock to mutex

2014-04-05 Thread Kristina Martšenko
On 04/04/14 16:30, Dan Carpenter wrote: > On Fri, Apr 04, 2014 at 02:46:14PM +0300, Kristina Martšenko wrote: > >> Yes, I didn't find any interrupt handlers either, which is partially why >> I thought it was (probably) safe. > > What's the other part of why it was safe? Put that stuff in the > c

Re: [PATCH] staging: goldfish: switch from spinlock to mutex

2014-04-04 Thread Dan Carpenter
On Fri, Apr 04, 2014 at 02:46:14PM +0300, Kristina Martšenko wrote: > Yes, I didn't find any interrupt handlers either, which is partially why > I thought it was (probably) safe. What's the other part of why it was safe? Put that stuff in the changelog. When we're reviewing patches we're always

Re: [PATCH] staging: goldfish: switch from spinlock to mutex

2014-04-04 Thread Kristina Martšenko
On 04/04/14 14:04, Dan Carpenter wrote: > On Fri, Apr 04, 2014 at 12:26:27PM +0300, Kristina Martšenko wrote: >> On 03/04/14 13:13, Dan Carpenter wrote: >>> On Thu, Apr 03, 2014 at 01:00:53PM +0300, Kristina Martšenko wrote: On 03/04/14 11:32, Dan Carpenter wrote: > On Tue, Mar 25, 2014 at

Re: [PATCH] staging: goldfish: switch from spinlock to mutex

2014-04-04 Thread Dan Carpenter
On Fri, Apr 04, 2014 at 12:26:27PM +0300, Kristina Martšenko wrote: > On 03/04/14 13:13, Dan Carpenter wrote: > > On Thu, Apr 03, 2014 at 01:00:53PM +0300, Kristina Martšenko wrote: > >> On 03/04/14 11:32, Dan Carpenter wrote: > >>> On Tue, Mar 25, 2014 at 01:45:09AM +0200, Kristina Martšenko wrote

Re: [PATCH] staging: goldfish: switch from spinlock to mutex

2014-04-04 Thread Kristina Martšenko
On 03/04/14 13:13, Dan Carpenter wrote: > On Thu, Apr 03, 2014 at 01:00:53PM +0300, Kristina Martšenko wrote: >> On 03/04/14 11:32, Dan Carpenter wrote: >>> On Tue, Mar 25, 2014 at 01:45:09AM +0200, Kristina Martšenko wrote: Use a mutex instead of a spinlock in goldfish_nand.c, as suggested by

Re: [PATCH] staging: goldfish: switch from spinlock to mutex

2014-04-03 Thread Dan Carpenter
On Thu, Apr 03, 2014 at 01:00:53PM +0300, Kristina Martšenko wrote: > On 03/04/14 11:32, Dan Carpenter wrote: > > Sorry for the delay, I'm just catching up with some old emails. > > No problem. > > > On Tue, Mar 25, 2014 at 01:45:09AM +0200, Kristina Martšenko wrote: > >> Use a mutex instead of a

Re: [PATCH] staging: goldfish: switch from spinlock to mutex

2014-04-03 Thread Kristina Martšenko
On 03/04/14 11:32, Dan Carpenter wrote: > Sorry for the delay, I'm just catching up with some old emails. No problem. > On Tue, Mar 25, 2014 at 01:45:09AM +0200, Kristina Martšenko wrote: >> Use a mutex instead of a spinlock in goldfish_nand.c, as suggested by >> the TODO list. >> >> Signed-off-b

Re: [PATCH] staging: goldfish: switch from spinlock to mutex

2014-04-03 Thread Dan Carpenter
Sorry for the delay, I'm just catching up with some old emails. On Tue, Mar 25, 2014 at 01:45:09AM +0200, Kristina Martšenko wrote: > Use a mutex instead of a spinlock in goldfish_nand.c, as suggested by > the TODO list. > > Signed-off-by: Kristina Martšenko Have you tested this change? regard

[PATCH] staging: goldfish: switch from spinlock to mutex

2014-03-24 Thread Kristina Martšenko
Use a mutex instead of a spinlock in goldfish_nand.c, as suggested by the TODO list. Signed-off-by: Kristina Martšenko --- drivers/staging/goldfish/README | 1 - drivers/staging/goldfish/goldfish_nand.c | 15 +++ 2 files changed, 7 insertions(+), 9 deletions(-) diff --git