On Thu, 29 Nov 2018 12:19:08 +
"Ardelean, Alexandru" wrote:
> On Tue, 2018-11-27 at 06:11 -0500, Popa, Stefan Serban wrote:
> > On Lu, 2018-11-26 at 17:24 -0200, Giuliano Belinassi wrote:
> > Hi, please see bellow
> >
>
> One note from me here.
>
> > > Hi, thank you for the review
> > >
On Tue, 2018-11-27 at 06:11 -0500, Popa, Stefan Serban wrote:
> On Lu, 2018-11-26 at 17:24 -0200, Giuliano Belinassi wrote:
> Hi, please see bellow
>
One note from me here.
> > Hi, thank you for the review
> >
> > >
> > > On Thu, 22 Nov 2018 11:01:00 +
> > > "Popa, Stefan Serban" wrote:
On Lu, 2018-11-26 at 17:24 -0200, Giuliano Belinassi wrote:
Hi, please see bellow
> Hi, thank you for the review
>
> >
> > On Thu, 22 Nov 2018 11:01:00 +
> > "Popa, Stefan Serban" wrote:
> > >
> > > I think that instead of setting the gain directly, we should use
> > > the
Hi, thank you for the review
> On Thu, 22 Nov 2018 11:01:00 +
> "Popa, Stefan Serban" wrote:
> > I think that instead of setting the gain directly, we should use
> > the IIO_CHAN_INFO_SCALE attribute. At page 12 of the ad7780 datasheet there
> > is a formula from which the output code can be
On Thu, 22 Nov 2018 11:01:00 +
"Popa, Stefan Serban" wrote:
> On Mi, 2018-11-21 at 16:04 -0200, Giuliano Belinassi wrote:
> > Previously, the AD7780 driver only supported gpio for the 'powerdown'
> > pin. This commit adds suppport for the 'gain' and 'filter' pin.
> Hey,
>
> Comments
On Mi, 2018-11-21 at 16:04 -0200, Giuliano Belinassi wrote:
> Previously, the AD7780 driver only supported gpio for the 'powerdown'
> pin. This commit adds suppport for the 'gain' and 'filter' pin.
Hey,
Comments inline.
>
> Signed-off-by: Giuliano Belinassi
> ---
>
Previously, the AD7780 driver only supported gpio for the 'powerdown'
pin. This commit adds suppport for the 'gain' and 'filter' pin.
Signed-off-by: Giuliano Belinassi
---
drivers/staging/iio/adc/ad7780.c | 61 --
include/linux/iio/adc/ad_sigma_delta.h | 5 +++
2
