Re: [PATCH] staging: mt7621-pci: refactor pci related read and writes functions

2018-07-08 Thread Sergio Paracuellos
On Mon, Jul 09, 2018 at 07:16:41AM +1000, NeilBrown wrote: > On Sun, Jul 08 2018, Sergio Paracuellos wrote: > > > > I can try to split this a bit but I don't really know how to do atomic > > changes because > > of the related things included here. > > Some suggestions: > > 1/ MV_READ_DATA is not

Re: [PATCH] staging: mt7621-pci: refactor pci related read and writes functions

2018-07-08 Thread NeilBrown
On Sun, Jul 08 2018, Sergio Paracuellos wrote: > > I can try to split this a bit but I don't really know how to do atomic > changes because > of the related things included here. Some suggestions: 1/ MV_READ_DATA is not used. Discard that any anything else that is not used. 2/ MV_WRITE is

Re: [PATCH] staging: mt7621-pci: refactor pci related read and writes functions

2018-07-08 Thread Sergio Paracuellos
On Sun, Jul 8, 2018 at 5:36 PM, Greg KH wrote: > On Sat, Jul 07, 2018 at 09:48:37PM +0200, Sergio Paracuellos wrote: >> This commit simplifies and clean a lot of stuff related with pci >> reads and writes. It deletes a lot of not needed at all functions >> and use kernel arch operations

Re: [PATCH] staging: mt7621-pci: refactor pci related read and writes functions

2018-07-08 Thread Greg KH
On Sat, Jul 07, 2018 at 09:48:37PM +0200, Sergio Paracuellos wrote: > This commit simplifies and clean a lot of stuff related with pci > reads and writes. It deletes a lot of not needed at all functions > and use kernel arch operations read[b,w,l] and write[b,w,l] instead > of use custom macros.

[PATCH] staging: mt7621-pci: refactor pci related read and writes functions

2018-07-07 Thread Sergio Paracuellos
This commit simplifies and clean a lot of stuff related with pci reads and writes. It deletes a lot of not needed at all functions and use kernel arch operations read[b,w,l] and write[b,w,l] instead of use custom macros. It also include one function helper called 'mt7621_pci_get_cfgaddr' to easily