Re: [PATCH] staging: octeon: repair "fixed-link" support

2020-10-09 Thread kernel test robot
Hi Alexander, I love your patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Alexander-A-Sverdlin/staging-octeon-repair-fixed-link-support/20201009-174828 base: https://git.kernel.org/pub/scm/linux/kernel/git/gr

Re: [PATCH] staging: octeon: repair "fixed-link" support

2020-10-09 Thread Greg Kroah-Hartman
On Fri, Oct 09, 2020 at 11:47:39AM +0200, Alexander A Sverdlin wrote: > From: Alexander Sverdlin > > The PHYs must be registered once in device probe function, not in device > open callback because it's only possible to register them once. > > Fixes: a25e278020 ("staging: octeon: support fixed-l

Re: [PATCH] staging: octeon: repair "fixed-link" support

2020-10-09 Thread kernel test robot
Hi Alexander, I love your patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Alexander-A-Sverdlin/staging-octeon-repair-fixed-link-support/20201009-174828 base: https://git.kernel.org/pub/scm/linux/kernel/git/gr

[PATCH] staging: octeon: repair "fixed-link" support

2020-10-09 Thread Alexander A Sverdlin
From: Alexander Sverdlin The PHYs must be registered once in device probe function, not in device open callback because it's only possible to register them once. Fixes: a25e278020 ("staging: octeon: support fixed-link phys") Signed-off-by: Alexander Sverdlin --- drivers/staging/octeon/ethernet

Re: [PATCH] staging: octeon: repair "fixed-link" support

2020-10-09 Thread Alexander Sverdlin
Hello Greg, Dave and all, the below patch is still applicable as-is, would you please re-consider it now, as the driver has been undeleted? On 08/01/2020 17:09, Alexander X Sverdlin wrote: > From: Alexander Sverdlin > > The PHYs must be registered once in device probe function, not in device >

Re: [PATCH] staging: octeon: repair "fixed-link" support

2020-10-09 Thread Greg Kroah-Hartman
On Fri, Oct 09, 2020 at 11:40:24AM +0200, Alexander Sverdlin wrote: > Hello Greg, Dave and all, > > the below patch is still applicable as-is, would you please re-consider it > now, > as the driver has been undeleted? > > On 08/01/2020 17:09, Alexander X Sverdlin wrote: Why would we have a patc

[PATCH] staging: octeon: repair "fixed-link" support

2020-10-09 Thread Alexander A Sverdlin
From: Alexander Sverdlin The PHYs must be registered once in device probe function, not in device open callback because it's only possible to register them once. Fixes: a25e278020 ("staging: octeon: support fixed-link phys") Signed-off-by: Alexander Sverdlin --- drivers/staging/octeon/ethernet

[PATCH] staging: octeon: repair "fixed-link" support

2020-01-08 Thread Alexander X Sverdlin
From: Alexander Sverdlin The PHYs must be registered once in device probe function, not in device open callback because it's only possible to register them once. Fixes: a25e278020 ("staging: octeon: support fixed-link phys") Signed-off-by: Alexander Sverdlin --- drivers/staging/octeon/ethernet