Re: [PATCH] Staging: rtl8192u: fix sparse warnings in r8192U_core.c

2014-08-07 Thread Antoine Schweitzer-Chaput
On Thu, Aug 07, 2014 at 10:10:47AM +0530, A Raghavendra Rao wrote: Signed-off-by: A Raghavendra Rao ar...@cdac.in This looks very similar to what I submitted on July 31st. At this time Greg had additional comments which led to a quite different patchset (though its review is not completed yet),

[PATCH] staging: rtl8192u: fix sparse warnings in r8192U_core.c

2014-08-06 Thread A Raghavendra Rao
Fix the following sparse warnings: drivers/staging/rtl8192u/r8192U_core.c:670:6: warning: symbol 'dump_eprom' was not declared. Should it be static? drivers/staging/rtl8192u/r8192U_core.c:1556:14: warning: symbol 'txqueue2outpipe' was not declared. Should it be static?

Re: [PATCH] staging: rtl8192u: fix sparse warnings in r8192U_core.c

2014-08-06 Thread Greg KH
On Wed, Aug 06, 2014 at 02:14:16PM +0530, A Raghavendra Rao wrote: Fix the following sparse warnings: drivers/staging/rtl8192u/r8192U_core.c:670:6: warning: symbol 'dump_eprom' was not declared. Should it be static? drivers/staging/rtl8192u/r8192U_core.c:1556:14: warning: symbol