Re: [PATCH] staging: rtl8723bs: remove obsolete commented out code

2021-02-11 Thread karthek
On Thu, Feb 11, 2021 at 4:16 PM Greg Kroah-Hartman wrote: > > A: http://en.wikipedia.org/wiki/Top_post > Q: Were do I find info about this thing called top-posting? > A: Because it messes up the order in which people normally read text. > Q: Why is top-posting such a bad thing? > A: Top-posting.

Re: [PATCH] staging: rtl8723bs: remove obsolete commented out code

2021-02-11 Thread Greg Kroah-Hartman
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I

Re: [PATCH] staging: rtl8723bs: remove obsolete commented out code

2021-02-11 Thread karthek
Should i send them as patch series? On Thu, Feb 11, 2021 at 1:27 PM Dan Carpenter wrote: > > On Thu, Feb 11, 2021 at 12:40:41AM +0530, karthik alapati wrote: > > @@ -867,10 +845,8 @@ static void PHY_HandleSwChnlAndSetBW8723B( > > if (bSetBandWidth) > > pHalData->bSetChnlBW =

Re: [PATCH] staging: rtl8723bs: remove obsolete commented out code

2021-02-10 Thread Dan Carpenter
On Thu, Feb 11, 2021 at 12:40:41AM +0530, karthik alapati wrote: > @@ -867,10 +845,8 @@ static void PHY_HandleSwChnlAndSetBW8723B( > if (bSetBandWidth) > pHalData->bSetChnlBW = true; > > - if (!pHalData->bSetChnlBW && !pHalData->bSwChnl) { > - /* DBG_871X("<=

Re: [PATCH] staging: rtl8723bs: remove obsolete commented out code

2021-02-10 Thread Dan Carpenter
On Thu, Feb 11, 2021 at 12:40:41AM +0530, karthik alapati wrote: > fix some checkpatch "Block comments use * on subsequent lines" > warnings and remove obsolete code > This isn't the correct commit message. It should say something like: "There is a bunch of messy, commented out code. Just

Re: [PATCH] staging: rtl8723bs: remove obsolete commented out code

2021-02-10 Thread Dan Carpenter
On Thu, Feb 11, 2021 at 12:49:30AM +0530, karthek wrote: > Hey dan, > check this out too I have no idea what you're talking about. Anyway, I just read my inbox in chronological order. That means I tend to send my replies before reading Greg's comments and before seeing the v2 patches. Just be

Re: [PATCH] staging: rtl8723bs: remove obsolete commented out code

2021-02-10 Thread karthek
Hey dan, check this out too ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: rtl8723bs: remove obsolete commented out code

2021-02-10 Thread karthik alapati
fix some checkpatch "Block comments use * on subsequent lines" warnings and remove obsolete code Suggested-by: Dan Carpenter Signed-off-by: karthik alapati --- .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 44 --- 1 file changed, 9 insertions(+), 35 deletions(-) diff --git