Re: [PATCH] staging: sm750fb: always take the lock

2017-06-26 Thread Geert Uytterhoeven
On Mon, Jun 26, 2017 at 11:16 AM, Frans Klaver wrote: > On Mon, Jun 26, 2017 at 11:11 AM, Geert Uytterhoeven > wrote: >> On Mon, Jun 26, 2017 at 7:45 AM, AbdAllah-MEZITI >> wrote: >>> This patch >>> - will always take

Re: [PATCH] staging: sm750fb: always take the lock

2017-06-26 Thread Frans Klaver
On Mon, Jun 26, 2017 at 11:11 AM, Geert Uytterhoeven wrote: > On Mon, Jun 26, 2017 at 7:45 AM, AbdAllah-MEZITI > wrote: >> This patch >> - will always take the lock > > Why? > > "The current code only takes the lock if multiple instances are

Re: [PATCH] staging: sm750fb: always take the lock

2017-06-26 Thread Geert Uytterhoeven
On Mon, Jun 26, 2017 at 7:45 AM, AbdAllah-MEZITI wrote: > This patch > - will always take the lock Why? "The current code only takes the lock if multiple instances are in use. This is error-prone, and confuses static analyzers. As taking the lock in case of a

Re: [PATCH] staging: sm750fb: always take the lock

2017-06-26 Thread Frans Klaver
There's no version number. Which one is the correct one? On Mon, Jun 26, 2017 at 7:45 AM, AbdAllah-MEZITI wrote: > This patch > - will always take the lock > - fix the sparse warning: > drivers/staging/sm750fb/sm750.c:159:13: warning: context imbalance in >

Re: [PATCH] staging: sm750fb: always take the lock

2017-06-26 Thread Frans Klaver
On Sun, Jun 25, 2017 at 11:39 PM, AbdAllah-MEZITI <abdallah.meziti@gmail.com> wrote: > Subject: [PATCH] staging: sm750fb: always take the lock When sending a new version of your patch, include a version number: Subject: [PATCH V2] staging: .

[PATCH] staging: sm750fb: always take the lock

2017-06-25 Thread AbdAllah-MEZITI
This patch - will always take the lock - fix the sparse warning: drivers/staging/sm750fb/sm750.c:159:13: warning: context imbalance in 'lynxfb_ops_fillrect' - different lock contexts for basic block drivers/staging/sm750fb/sm750.c:231:9: warning: context imbalance in 'lynxfb_ops_copyarea' -

Re: [PATCH] staging: sm750fb: always take the lock

2017-06-25 Thread Greg Kroah-Hartman
On Sun, Jun 25, 2017 at 11:39:20PM +0200, AbdAllah-MEZITI wrote: > Signed-off-by: AbdAllah MEZITI I can't take patches without any changelog text, sorry. greg k-h ___ devel mailing list de...@linuxdriverproject.org

[PATCH] staging: sm750fb: always take the lock

2017-06-25 Thread AbdAllah-MEZITI
Signed-off-by: AbdAllah MEZITI --- drivers/staging/sm750fb/sm750.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 386d4ad..4a22190 100644 ---