Re: [PATCH 00/11] staging: comedi: s626: more cleanups

2013-10-19 Thread Greg Kroah-Hartman
On Fri, Oct 18, 2013 at 02:40:48PM +0100, Ian Abbott wrote: Tidy up the s626 driver a bit more. In particular, the handling of encoder setup values is a bit hard to follow with lots of bit-shifting and masking, particularly when converting between the standardized setup values and the 'CRA'

Re: [PATCH 00/11] staging: comedi: s626: more cleanups

2013-10-19 Thread Ian Abbott
On 19/10/13 21:48, Greg Kroah-Hartman wrote: On Fri, Oct 18, 2013 at 02:40:48PM +0100, Ian Abbott wrote: Tidy up the s626 driver a bit more. In particular, the handling of encoder setup values is a bit hard to follow with lots of bit-shifting and masking, particularly when converting between

[PATCH 00/11] staging: comedi: s626: more cleanups

2013-10-18 Thread Ian Abbott
Tidy up the s626 driver a bit more. In particular, the handling of encoder setup values is a bit hard to follow with lots of bit-shifting and masking, particularly when converting between the standardized setup values and the 'CRA' and 'CRB' register values. (There are 6 encoders in all, split