Re: [PATCH 00/11] staging: wilc1000: fix for checkpatch and handled malloc memory properly

2018-04-23 Thread Greg KH
On Wed, Apr 04, 2018 at 10:45:25AM +0530, Ajay Singh wrote: > Hi Greg, > > On Wed, 28 Mar 2018 13:31:01 +0200 > Greg KH wrote: > > > On Tue, Mar 27, 2018 at 12:52:13PM +0530, Ajay Singh wrote: > > > > > > Please let me know, in case I have to rework and resubmit

Re: [PATCH 00/11] staging: wilc1000: fix for checkpatch and handled malloc memory properly

2018-04-03 Thread Ajay Singh
Hi Greg, On Wed, 28 Mar 2018 13:31:01 +0200 Greg KH wrote: > On Tue, Mar 27, 2018 at 12:52:13PM +0530, Ajay Singh wrote: > > > > Please let me know, in case I have to rework and resubmit this > > patch series to make them into staging branch. > > You already sent

Re: [PATCH 00/11] staging: wilc1000: fix for checkpatch and handled malloc memory properly

2018-03-28 Thread Greg KH
On Tue, Mar 27, 2018 at 12:52:13PM +0530, Ajay Singh wrote: > > Please let me know, in case I have to rework and resubmit this patch > series to make them into staging branch. You already sent a v2 series for this, right? Why respond to the v1 set? confused, greg k-h

Re: [PATCH 00/11] staging: wilc1000: fix for checkpatch and handled malloc memory properly

2018-03-27 Thread Ajay Singh
Hi Claudiu, On Tue, 27 Mar 2018 11:55:52 +0300 Claudiu Beznea wrote: > On 27.03.2018 10:22, Ajay Singh wrote: > > > > Please let me know, in case I have to rework and resubmit this patch > > series to make them into staging branch. > > > > As I suggested in

Re: [PATCH 00/11] staging: wilc1000: fix for checkpatch and handled malloc memory properly

2018-03-27 Thread Claudiu Beznea
On 27.03.2018 10:22, Ajay Singh wrote: > > Please let me know, in case I have to rework and resubmit this patch > series to make them into staging branch. > As I suggested in patch 6, I prefer having the same format for wilc_wfi_cfg_tx_vendor_spec() and wilc_wfi_cfg_parse_rx_vendor_spec(). I

Re: [PATCH 00/11] staging: wilc1000: fix for checkpatch and handled malloc memory properly

2018-03-27 Thread Ajay Singh
Please let me know, in case I have to rework and resubmit this patch series to make them into staging branch. Regards, Ajay ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 00/11] staging: wilc1000: fix for checkpatch and handled malloc memory properly

2018-03-21 Thread Claudiu Beznea
Patch 6 may be reworked a bit. Other than this: Reviewed-by: Claudiu Beznea On 21.03.2018 11:20, Ajay Singh wrote: > Hi Dan, > > On Wed, 21 Mar 2018 10:51:16 +0300 > Dan Carpenter wrote: > >> These look good. I've reviewed them all. >>

Re: [PATCH 00/11] staging: wilc1000: fix for checkpatch and handled malloc memory properly

2018-03-21 Thread Ajay Singh
Hi Dan, On Wed, 21 Mar 2018 10:51:16 +0300 Dan Carpenter wrote: > These look good. I've reviewed them all. > > Reviewed-by: Dan Carpenter Thanks for reviewing all the patches. > > I had some small process complaints but it doesn't make

Re: [PATCH 00/11] staging: wilc1000: fix for checkpatch and handled malloc memory properly

2018-03-21 Thread Dan Carpenter
These look good. I've reviewed them all. Reviewed-by: Dan Carpenter I had some small process complaints but it doesn't make life easier for me if you resend them and I have to review everything twice :P regards, dan carpenter

[PATCH 00/11] staging: wilc1000: fix for checkpatch and handled malloc memory properly

2018-03-20 Thread Ajay Singh
This patch series contains fixes to avoid checkpatch issues and removed unused code. Few patch contains changes related to NULL check and freeing of dynamically allocated memory. Ajay Singh (11): staging: wilc1000: refactor scan() to free kmalloc memory on failure cases staging: