Re: [PATCH 04/11] staging: wilc1000: refactor WILC_WFI_p2p_rx() to avoid line over 80 char

Also good for me, only one minor thing mentioned below. On 20.03.2018 18:55, Ajay Singh wrote: > + if (subtype == GO_NEG_REQ || subtype == GO_NEG_RSP || > + subtype == P2P_INV_REQ || subtype == P2P_INV_RSP) { > + for (i = P2P_PUB_ACTION_SUBTYPE + 2; i < size; i++) { > +

Re: [PATCH 04/11] staging: wilc1000: refactor WILC_WFI_p2p_rx() to avoid line over 80 char

This one would have been easier for me to review if it were broken up slightly differently. I have a script to review when people split functions up, but there were a bunch of other stuff so my script gets confused. Anyway, looks good. regards, dan carpenter

[PATCH 04/11] staging: wilc1000: refactor WILC_WFI_p2p_rx() to avoid line over 80 char

Fix 'line over 80 characters' issue found by checkpatch.pl script. Refactor and split the function to avoid the checkpatch reported issues. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 145 -- 1 file changed, 82