Re: [PATCH 09/10] staging: ks7010: remove zero comparison

2017-03-22 Thread Dan Carpenter
On Wed, Mar 22, 2017 at 10:22:24AM +1100, Tobin C. Harding wrote: > On Tue, Mar 21, 2017 at 03:49:22PM +0300, Dan Carpenter wrote: > > On Tue, Mar 21, 2017 at 01:37:11PM +1100, Tobin C. Harding wrote: > > > Comparison, equal to zero, is redundant > > > > > > 'if (foo == 0)' is equal to 'if

Re: [PATCH 09/10] staging: ks7010: remove zero comparison

2017-03-21 Thread Tobin C. Harding
On Tue, Mar 21, 2017 at 03:49:22PM +0300, Dan Carpenter wrote: > On Tue, Mar 21, 2017 at 01:37:11PM +1100, Tobin C. Harding wrote: > > Comparison, equal to zero, is redundant > > > > 'if (foo == 0)' is equal to 'if (!foo)' > > > > Typical kernel coding style is to use the shorter form. > > >

Re: [PATCH 09/10] staging: ks7010: remove zero comparison

2017-03-21 Thread Dan Carpenter
On Tue, Mar 21, 2017 at 01:37:11PM +1100, Tobin C. Harding wrote: > Comparison, equal to zero, is redundant > > 'if (foo == 0)' is equal to 'if (!foo)' > > Typical kernel coding style is to use the shorter form. > > Remove unnecessary zero comparison. Not exactly. If you're talking about

[PATCH 09/10] staging: ks7010: remove zero comparison

2017-03-20 Thread Tobin C. Harding
Comparison, equal to zero, is redundant 'if (foo == 0)' is equal to 'if (!foo)' Typical kernel coding style is to use the shorter form. Remove unnecessary zero comparison. Signed-off-by: Tobin C. Harding --- drivers/staging/ks7010/ks_wlan_net.c | 4 ++-- 1 file changed, 2