Re: [PATCH 09/12] netdevsim: Implement ndo_get_port_parent_id()

2019-02-05 Thread kbuild test robot
Hi Florian, I love your patch! Yet something to improve: [auto build test ERROR on net/master] [also build test ERROR on next-20190205] [cannot apply to v5.0-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 09/12] netdevsim: Implement ndo_get_port_parent_id()

2019-02-05 Thread kbuild test robot
Hi Florian, I love your patch! Yet something to improve: [auto build test ERROR on net/master] [also build test ERROR on next-20190205] [cannot apply to v5.0-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 09/12] netdevsim: Implement ndo_get_port_parent_id()

2019-02-04 Thread Jakub Kicinski
On Mon, 4 Feb 2019 15:36:30 -0800, Florian Fainelli wrote: > netdevsim only supports SWITCHDEV_ATTR_ID_PORT_PARENT_ID, which makes it a > great candidate to be converted to use the ndo_get_port_parent_id() NDO > instead of implementing switchdev_port_attr_get(). > > Signed-off-by: Florian

[PATCH 09/12] netdevsim: Implement ndo_get_port_parent_id()

2019-02-04 Thread Florian Fainelli
netdevsim only supports SWITCHDEV_ATTR_ID_PORT_PARENT_ID, which makes it a great candidate to be converted to use the ndo_get_port_parent_id() NDO instead of implementing switchdev_port_attr_get(). Signed-off-by: Florian Fainelli --- drivers/net/netdevsim/netdev.c | 22 ++ 1