Re: 答复: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

2017-06-29 Thread Greg Kroah-Hartman
A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Wed, Jun 28, 2017 at 06:18:57AM +, Teddy Wang 王力强 wrote: > Hi Greg, > > Is the reason Sudip gave you for the question of

答复: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

2017-06-28 Thread Teddy Wang 王力强
Hi Greg, Is the reason Sudip gave you for the question of "why" sufficient ? This patch is very important for the driver running in the X86 platform. Without this patch, many SM750 graphic chip customers complain the Ubuntu OS can't run well. When they install the OS, the screen will

Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

2017-06-25 Thread Sudip Mukherjee
On Sun, Jun 25, 2017 at 04:27:23PM +0200, Greg Kroah-Hartman wrote: > On Sun, Jun 25, 2017 at 02:54:29PM +0100, Sudip Mukherjee wrote: > > On Sun, Jun 25, 2017 at 02:54:51PM +0200, Greg Kroah-Hartman wrote: > > > On Sun, Jun 25, 2017 at 01:43:34PM +0100, Sudip Mukherjee wrote: > > > > On Mon, Jun

Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

2017-06-25 Thread Greg Kroah-Hartman
On Sun, Jun 25, 2017 at 02:54:29PM +0100, Sudip Mukherjee wrote: > On Sun, Jun 25, 2017 at 02:54:51PM +0200, Greg Kroah-Hartman wrote: > > On Sun, Jun 25, 2017 at 01:43:34PM +0100, Sudip Mukherjee wrote: > > > On Mon, Jun 19, 2017 at 09:32:57PM +0100, Sudip Mukherjee wrote: > > > > From: Teddy

Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

2017-06-25 Thread Sudip Mukherjee
On Sun, Jun 25, 2017 at 02:54:51PM +0200, Greg Kroah-Hartman wrote: > On Sun, Jun 25, 2017 at 01:43:34PM +0100, Sudip Mukherjee wrote: > > On Mon, Jun 19, 2017 at 09:32:57PM +0100, Sudip Mukherjee wrote: > > > From: Teddy Wang > > > > > > If vesafb is enabled in the

Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

2017-06-25 Thread Greg Kroah-Hartman
On Sun, Jun 25, 2017 at 01:43:34PM +0100, Sudip Mukherjee wrote: > On Mon, Jun 19, 2017 at 09:32:57PM +0100, Sudip Mukherjee wrote: > > From: Teddy Wang > > > > If vesafb is enabled in the config then /dev/fb0 is created by vesa > > and this sm750 driver gets fb1,

Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

2017-06-25 Thread Sudip Mukherjee
On Mon, Jun 19, 2017 at 09:32:57PM +0100, Sudip Mukherjee wrote: > From: Teddy Wang > > If vesafb is enabled in the config then /dev/fb0 is created by vesa > and this sm750 driver gets fb1, fb2. But we need to be fb0 and fb1 to > effectively work with xorg. > So if

Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

2017-06-20 Thread Sudip Mukherjee
On Tue, Jun 20, 2017 at 11:40:59PM +0300, Andy Shevchenko wrote: > On Tue, Jun 20, 2017 at 11:20 PM, Dan Carpenter > wrote: > > That's totally bogus. Just say you don't know. It's never a > > reguirement that people fix AMD drivers before they can review code... > >

Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

2017-06-20 Thread Sudip Mukherjee
Hi Dan, On Tue, Jun 20, 2017 at 11:20:55PM +0300, Dan Carpenter wrote: > That's totally bogus. Just say you don't know. It's never a > reguirement that people fix AMD drivers before they can review code... Yes, I don't know how drm drivers work, so I blindly follow what has been done there.

Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

2017-06-20 Thread Andy Shevchenko
On Tue, Jun 20, 2017 at 11:20 PM, Dan Carpenter wrote: > That's totally bogus. Just say you don't know. It's never a > reguirement that people fix AMD drivers before they can review code... Agree. It's not a cargo cult. If there any real thing behind that #ifdef I

Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

2017-06-20 Thread Dan Carpenter
That's totally bogus. Just say you don't know. It's never a reguirement that people fix AMD drivers before they can review code... regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

2017-06-20 Thread Sudip Mukherjee
On Mon, Jun 19, 2017 at 11:47:20PM +0300, Andy Shevchenko wrote: > On Mon, Jun 19, 2017 at 11:32 PM, Sudip Mukherjee > wrote: > > > > +#ifdef CONFIG_X86 > > + primary = pdev->resource[PCI_ROM_RESOURCE].flags & > > +

Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

2017-06-19 Thread Andy Shevchenko
On Mon, Jun 19, 2017 at 11:32 PM, Sudip Mukherjee wrote: > +#ifdef CONFIG_X86 > + primary = pdev->resource[PCI_ROM_RESOURCE].flags & > + IORESOURCE_ROM_SHADOW; > +#endif Why do we need #ifdef? In any case you may

[PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

2017-06-19 Thread Sudip Mukherjee
From: Teddy Wang If vesafb is enabled in the config then /dev/fb0 is created by vesa and this sm750 driver gets fb1, fb2. But we need to be fb0 and fb1 to effectively work with xorg. So if it has been alloted fb1, then try to remove the other fb0. Signed-off-by: