Re: [PATCH 1/2] staging: vchiq: Fix bulk userdata handling

2021-01-05 Thread Arnd Bergmann
On Tue, Jan 5, 2021 at 12:53 PM Phil Elwell wrote: > On Tue, 5 Jan 2021 at 11:04, Dan Carpenter wrote: > > > > Mixing __user pointers and regular pointers is dangerous and has lead to > > security problems in this driver in the past. But also mixing mixing > > tokens with pointers just makes

Re: [PATCH 1/2] staging: vchiq: Fix bulk userdata handling

2021-01-05 Thread Dan Carpenter
On Tue, Jan 05, 2021 at 11:53:32AM +, Phil Elwell wrote: > On Tue, 5 Jan 2021 at 11:04, Dan Carpenter wrote: > > > > On Mon, Jan 04, 2021 at 07:26:42PM +, Phil Elwell wrote: > > > On 04/01/2021 18:31, Dan Carpenter wrote: > > > > On Mon, Jan 04, 2021 at 12:09:27PM +, Phil Elwell

Re: [PATCH 1/2] staging: vchiq: Fix bulk userdata handling

2021-01-05 Thread Phil Elwell
On Tue, 5 Jan 2021 at 11:04, Dan Carpenter wrote: > > On Mon, Jan 04, 2021 at 07:26:42PM +, Phil Elwell wrote: > > On 04/01/2021 18:31, Dan Carpenter wrote: > > > On Mon, Jan 04, 2021 at 12:09:27PM +, Phil Elwell wrote: > > > > The addition of the local 'userdata' pointer to > > > >

Re: [PATCH 1/2] staging: vchiq: Fix bulk userdata handling

2021-01-05 Thread Dan Carpenter
On Mon, Jan 04, 2021 at 07:26:42PM +, Phil Elwell wrote: > On 04/01/2021 18:31, Dan Carpenter wrote: > > On Mon, Jan 04, 2021 at 12:09:27PM +, Phil Elwell wrote: > > > The addition of the local 'userdata' pointer to > > > vchiq_irq_queue_bulk_tx_rx omitted the case where neither BLOCKING

Re: [PATCH 1/2] staging: vchiq: Fix bulk userdata handling

2021-01-04 Thread Phil Elwell
On 04/01/2021 18:31, Dan Carpenter wrote: On Mon, Jan 04, 2021 at 12:09:27PM +, Phil Elwell wrote: The addition of the local 'userdata' pointer to vchiq_irq_queue_bulk_tx_rx omitted the case where neither BLOCKING nor WAITING modes are used, in which case the value provided by the caller is

Re: [PATCH 1/2] staging: vchiq: Fix bulk userdata handling

2021-01-04 Thread Dan Carpenter
On Mon, Jan 04, 2021 at 12:09:27PM +, Phil Elwell wrote: > The addition of the local 'userdata' pointer to > vchiq_irq_queue_bulk_tx_rx omitted the case where neither BLOCKING nor > WAITING modes are used, in which case the value provided by the > caller is replaced with a NULL. > > Fixes:

Re: [PATCH 1/2] staging: vchiq: Fix bulk userdata handling

2021-01-04 Thread Stefan Wahren
Am 04.01.21 um 13:09 schrieb Phil Elwell: > The addition of the local 'userdata' pointer to > vchiq_irq_queue_bulk_tx_rx omitted the case where neither BLOCKING nor > WAITING modes are used, in which case the value provided by the > caller is replaced with a NULL. > > Fixes: 4184da4f316a

[PATCH 1/2] staging: vchiq: Fix bulk userdata handling

2021-01-04 Thread Phil Elwell
The addition of the local 'userdata' pointer to vchiq_irq_queue_bulk_tx_rx omitted the case where neither BLOCKING nor WAITING modes are used, in which case the value provided by the caller is replaced with a NULL. Fixes: 4184da4f316a ("staging: vchiq: fix __user annotations") Signed-off-by: