Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

2017-03-21 Thread Michael Zoran
On Tue, 2017-03-21 at 23:30 +0300, Dan Carpenter wrote: > I've read Stefan's review comments and intervened where I didn't > understand them.  The recent ones are very specific and reasonable... > > Just send a v2.  I don't get what the deal is... Partly because Eric and Stefan have publically

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

2017-03-21 Thread Dan Carpenter
I've read Stefan's review comments and intervened where I didn't understand them. The recent ones are very specific and reasonable... Just send a v2. I don't get what the deal is... regards, dan carpenter ___ devel mailing list

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

2017-03-20 Thread Michael Zoran
On Mon, 2017-03-20 at 11:54 -0700, Michael Zoran wrote: > On Mon, 2017-03-20 at 10:28 -0700, Michael Zoran wrote: > > On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote: > > > Michael Zoran writes: > > > > > > > > > Since the API is completely documented, I see no reason

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

2017-03-20 Thread Michael Zoran
On Mon, 2017-03-20 at 10:28 -0700, Michael Zoran wrote: > On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote: > > Michael Zoran writes: > > > > > > > Since the API is completely documented, I see no reason we or > > > > > anybody > > > > > couldn't essentially rewrite the

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

2017-03-20 Thread Michael Zoran
On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote: > Michael Zoran writes: > > > > > Since the API is completely documented, I see no reason we or > > > > anybody > > > > couldn't essentially rewrite the driver while it's in > > > > staging.  I > > > > just > > > > think

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

2017-03-20 Thread Eric Anholt
Michael Zoran writes: >> > Since the API is completely documented, I see no reason we or >> > anybody >> > couldn't essentially rewrite the driver while it's in staging.  I >> > just >> > think it would be best for everyone if the new version was a drop >> > in >> >

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

2017-03-20 Thread Dan Carpenter
On Sat, Mar 18, 2017 at 09:42:43PM -0700, Michael Zoran wrote: > On Sat, 2017-03-18 at 14:23 +0100, Stefan Wahren wrote: > > > Michael Zoran hat am 17. März 2017 um 16:22 > > > geschrieben: > > > > > > > > > From: Dave Stevenson > > > > > >

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

2017-03-19 Thread Michael Zoran
> > Since the API is completely documented, I see no reason we or > > anybody > > couldn't essentially rewrite the driver while it's in staging.  I > > just > > think it would be best for everyone if the new version was a drop > > in > > replacement for the original version.  Essential an

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

2017-03-19 Thread Stefan Wahren
> Michael Zoran hat am 19. März 2017 um 12:38 geschrieben: > > ... > > Sorry, I simply meant that I was hoping the comments would focus on > changes I made to the driver not the original version. I don't want > things to get mixed up between what I wrote and what Dave

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

2017-03-19 Thread Michael Zoran
On Sun, 2017-03-19 at 11:39 +0100, Stefan Wahren wrote: > Hi Michael, > > > Michael Zoran hat am 19. März 2017 um 05:42 > > geschrieben: > > > > > > On Sat, 2017-03-18 at 14:23 +0100, Stefan Wahren wrote: > > > > Michael Zoran hat am 17. März 2017 um

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

2017-03-19 Thread Stefan Wahren
Hi Michael, > Michael Zoran hat am 19. März 2017 um 05:42 geschrieben: > > > On Sat, 2017-03-18 at 14:23 +0100, Stefan Wahren wrote: > > > Michael Zoran hat am 17. März 2017 um 16:22 > > > geschrieben: > > > > > > > > > From: Dave Stevenson

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

2017-03-18 Thread Michael Zoran
On Sat, 2017-03-18 at 14:23 +0100, Stefan Wahren wrote: > > Michael Zoran hat am 17. März 2017 um 16:22 > > geschrieben: > > > > > > From: Dave Stevenson > > > > Pi3 and Compute Module 3 have a GPIO expander that the > > VPU communicates

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

2017-03-18 Thread Stefan Wahren
> Michael Zoran hat am 17. März 2017 um 16:22 geschrieben: > > > From: Dave Stevenson > > Pi3 and Compute Module 3 have a GPIO expander that the > VPU communicates with. > There is a mailbox service that now allows control of this >

[PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

2017-03-17 Thread Michael Zoran
From: Dave Stevenson Pi3 and Compute Module 3 have a GPIO expander that the VPU communicates with. There is a mailbox service that now allows control of this expander, so add a kernel driver that can make use of it. Pwr_led node added to device-tree for Pi3.