There are two possible values for HDD activity behavior:

        - 0 Normally off, ON when active
        - 1 Normally on, OFF when active

Implement a logic to set it.

Signed-off-by: Mauro Carvalho Chehab <mchehab+hua...@kernel.org>
---
 drivers/staging/nuc-led/nuc-wmi.c | 77 +++++++++++++++++++++++++++++++
 1 file changed, 77 insertions(+)

diff --git a/drivers/staging/nuc-led/nuc-wmi.c 
b/drivers/staging/nuc-led/nuc-wmi.c
index 1a6e2b17c888..68143d45c34c 100644
--- a/drivers/staging/nuc-led/nuc-wmi.c
+++ b/drivers/staging/nuc-led/nuc-wmi.c
@@ -1626,10 +1626,86 @@ static umode_t nuc_wmi_led_blink_is_visible(struct 
kobject *kobj,
        return 0;
 }
 
+/* HDD activity behavior */
+static ssize_t show_hdd_default(struct device *dev,
+                                  struct device_attribute *attr,
+                                  char *buf)
+{
+       struct led_classdev *cdev = dev_get_drvdata(dev);
+       struct nuc_nmi_led *led = container_of(cdev, struct nuc_nmi_led, cdev);
+       u8 input[NUM_INPUT_ARGS] = { 0 };
+       u8 output[NUM_OUTPUT_ARGS];
+       int ctrl, ret, val;
+
+       if (led->indicator != LED_IND_HDD_ACTIVITY)
+               return -EINVAL;
+
+       ctrl = led->reg_table[led->indicator][LED_FUNC_HDD_BEHAVIOR];
+
+       if (!nuc_wmi_test_control(dev, led, ctrl))
+               return -ENODEV;
+
+       input[0] = LED_NEW_GET_CONTROL_ITEM;
+       input[1] = led->id;
+       input[2] = led->indicator;
+       input[3] = ctrl;
+
+       ret = nuc_nmi_cmd(dev, LED_NEW_GET_STATUS, input, output);
+       if (ret)
+               return ret;
+
+       val = output[0];
+
+       if (val == 0)
+               return scnprintf(buf, PAGE_SIZE, "off\n");
+
+       return scnprintf(buf, PAGE_SIZE, "on\n");
+}
+
+static ssize_t store_hdd_default(struct device *dev,
+                                   struct device_attribute *attr,
+                                   const char *buf, size_t len)
+{
+       struct led_classdev *cdev = dev_get_drvdata(dev);
+       struct nuc_nmi_led *led = container_of(cdev, struct nuc_nmi_led, cdev);
+       u8 input[NUM_INPUT_ARGS] = { 0 };
+       int ctrl, val, ret;
+       const char *tmp;
+
+       if (led->indicator != LED_IND_HDD_ACTIVITY)
+               return -EINVAL;
+
+       ctrl = led->reg_table[led->indicator][LED_FUNC_HDD_BEHAVIOR];
+
+       if (!nuc_wmi_test_control(dev, led, ctrl))
+               return -ENODEV;
+
+       tmp = strsep((char **)&buf, "\n");
+       if (!strcmp(tmp, "on"))
+               val = 1;
+       else if (!strcmp(tmp, "off"))
+               val = 0;
+       else
+               return -EINVAL;
+
+       input[0] = led->id;
+       input[1] = led->indicator;
+       input[2] = ctrl;
+       input[3] = val;
+
+       ret = nuc_nmi_cmd(dev, LED_SET_VALUE, input, NULL);
+       if (ret)
+               return ret;
+
+       return len;
+}
+
+
 static LED_ATTR_RW(indicator);
 static LED_ATTR_RW(color);
 static LED_ATTR_RW(blink_behavior);
 static LED_ATTR_RW(blink_frequency);
+static LED_ATTR_RW(hdd_default);
 
 LED_ATTR_POWER_STATE_RW(s0_brightness, brightness, 0);
 LED_ATTR_POWER_STATE_RW(s0_blink_behavior, blink_behavior, 0);
@@ -1657,6 +1733,7 @@ LED_ATTR_POWER_STATE_RW(standby_blink_frequency, 
blink_frequency, 2);
 
 static struct attribute *nuc_wmi_led_attr[] = {
        &dev_attr_indicator.attr,
+       &dev_attr_hdd_default.attr,
        NULL,
 };
 
-- 
2.31.1

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to