Re: [PATCH 17/17] staging: nuc-led: update the TODOs

2021-05-17 Thread Mauro Carvalho Chehab
Em Mon, 17 May 2021 10:05:27 +0200 Pavel Machek escreveu: > No. Take a look at triggers; for example hdd monitor should look very > much like existing disk trigger. Hmm... after looking at triggers, I'm not sure if this is the right interface, nor if we're talking about the same thing. See, at

Re: [PATCH 17/17] staging: nuc-led: update the TODOs

2021-05-17 Thread Mauro Carvalho Chehab
Em Mon, 17 May 2021 10:57:49 +0200 Mauro Carvalho Chehab escreveu: > Em Mon, 17 May 2021 10:05:27 +0200 > Pavel Machek escreveu: > > No. Take a look at triggers; for example hdd monitor should look very > > much like existing disk trigger. Btw, is there a way to trigger brightness? When a

Re: [PATCH 17/17] staging: nuc-led: update the TODOs

2021-05-17 Thread Mauro Carvalho Chehab
Em Mon, 17 May 2021 10:05:27 +0200 Pavel Machek escreveu: > Hi! > > > > > - Need to validate the uAPI and document it before moving > > > >this driver out of staging. > > > > > > > - Stabilize and document its sysfs interface. > > > > > > Would you mind starting with this

Re: [PATCH 17/17] staging: nuc-led: update the TODOs

2021-05-17 Thread Pavel Machek
Hi! > > > - Need to validate the uAPI and document it before moving > > >this driver out of staging. > > > > > - Stabilize and document its sysfs interface. > > > > Would you mind starting with this one? > > Do you mean writing the ABI document for it? Surely I can do that, > but

Re: [PATCH 17/17] staging: nuc-led: update the TODOs

2021-05-17 Thread Mauro Carvalho Chehab
Hi Pavel, Em Sun, 16 May 2021 20:21:50 +0200 Pavel Machek escreveu: > Hi! > > > - Need to validate the uAPI and document it before moving > >this driver out of staging. > > > - Stabilize and document its sysfs interface. > > Would you mind starting with this one? Do you mean

Re: [PATCH 17/17] staging: nuc-led: update the TODOs

2021-05-16 Thread Pavel Machek
Hi! > - Need to validate the uAPI and document it before moving >this driver out of staging. > - Stabilize and document its sysfs interface. Would you mind starting with this one? We should have existing APIs for most of functionality described... We really don't want to merge code

[PATCH 17/17] staging: nuc-led: update the TODOs

2021-05-16 Thread Mauro Carvalho Chehab
Now that most functionality were merged at the driver, update its TODO list, and add a "TODO" comment for the two WMI API commands that are currently not implemented. In summary: - on Rev 0.64, command 0x07 (LED_NOTIFICATION) is meant to store all config settings at EEPROM. That doesn't seem