Re: [PATCH 19/51] staging: comedi: me4000: refactor request_irq() during attach

2013-12-04 Thread Ian Abbott
On 2013-12-03 19:07, H Hartley Sweeten wrote: Do the request_irq() before setting up the subdevices. This removes an indent level and makes the code a bit cleaner. Also, remove the dev_warn() noise about the irq. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott

Re: [PATCH 19/51] staging: comedi: me4000: refactor request_irq() during attach

2013-12-04 Thread Dan Carpenter
On Wed, Dec 04, 2013 at 11:10:05AM +, Ian Abbott wrote: On 2013-12-03 19:07, H Hartley Sweeten wrote: Do the request_irq() before setting up the subdevices. This removes an indent level and makes the code a bit cleaner. Also, remove the dev_warn() noise about the irq. Signed-off-by: H

Re: [PATCH 19/51] staging: comedi: me4000: refactor request_irq() during attach

2013-12-04 Thread Ian Abbott
On 2013/12/04 01:05 PM, Dan Carpenter wrote: On Wed, Dec 04, 2013 at 11:10:05AM +, Ian Abbott wrote: On 2013-12-03 19:07, H Hartley Sweeten wrote: Do the request_irq() before setting up the subdevices. This removes an indent level and makes the code a bit cleaner. Also, remove the

[PATCH 19/51] staging: comedi: me4000: refactor request_irq() during attach

2013-12-03 Thread H Hartley Sweeten
Do the request_irq() before setting up the subdevices. This removes an indent level and makes the code a bit cleaner. Also, remove the dev_warn() noise about the irq. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman