Re: [PATCH 2/2] dt-bindings: document gpio-mt7621 bindings

2018-06-14 Thread Sergio Paracuellos
On Thu, Jun 14, 2018 at 4:17 PM, Linus Walleij wrote: > On Thu, Jun 14, 2018 at 6:45 AM, Sergio Paracuellos > wrote: > >> Ok, so... does the following single node sounds acceptable? >> >> gpio: gpio@600 { >> #gpio-cells = <2>; >> #interrupt-cells = <2>; >> compatible =

Re: [PATCH 2/2] dt-bindings: document gpio-mt7621 bindings

2018-06-14 Thread Linus Walleij
On Thu, Jun 14, 2018 at 4:33 PM, Rob Herring wrote: > On Thu, Jun 14, 2018 at 8:14 AM, Linus Walleij > wrote: >> On Wed, Jun 13, 2018 at 9:28 PM, Rob Herring wrote: >> "Some system-on-chips (SoCs) use the concept of GPIO banks. ... Usually each such bank is exposed in the device

Re: [PATCH 2/2] dt-bindings: document gpio-mt7621 bindings

2018-06-14 Thread Rob Herring
On Thu, Jun 14, 2018 at 8:14 AM, Linus Walleij wrote: > On Wed, Jun 13, 2018 at 9:28 PM, Rob Herring wrote: > >>> "Some system-on-chips (SoCs) use the concept of GPIO banks. ... >>> Usually each such bank is >>> exposed in the device tree as an individual gpio-controller node. ..." >> >> This

Re: [PATCH 2/2] dt-bindings: document gpio-mt7621 bindings

2018-06-14 Thread Linus Walleij
On Thu, Jun 14, 2018 at 6:45 AM, Sergio Paracuellos wrote: > Ok, so... does the following single node sounds acceptable? > > gpio: gpio@600 { > #gpio-cells = <2>; > #interrupt-cells = <2>; > compatible = "mediatek,mt7621-gpio"; > gpio-controller; > interrupt-controller; > reg =

Re: [PATCH 2/2] dt-bindings: document gpio-mt7621 bindings

2018-06-14 Thread Linus Walleij
On Wed, Jun 13, 2018 at 9:28 PM, Rob Herring wrote: >> "Some system-on-chips (SoCs) use the concept of GPIO banks. ... >> Usually each such bank is >> exposed in the device tree as an individual gpio-controller node. ..." > > This should be conditioned on being able to divide up the registers by

Re: [PATCH 2/2] dt-bindings: document gpio-mt7621 bindings

2018-06-13 Thread Sergio Paracuellos
On Wed, Jun 13, 2018 at 01:28:35PM -0600, Rob Herring wrote: > On Wed, Jun 13, 2018 at 10:23 AM, Sergio Paracuellos > wrote: > > Hi Rob, > > > > Thanks for your time in reviewing this. > > > > On Tue, Jun 12, 2018 at 10:56 PM, Rob Herring wrote: > >> On Sat, Jun 02, 2018 at 09:30:10AM +0200,

Re: [PATCH 2/2] dt-bindings: document gpio-mt7621 bindings

2018-06-13 Thread Rob Herring
On Wed, Jun 13, 2018 at 10:23 AM, Sergio Paracuellos wrote: > Hi Rob, > > Thanks for your time in reviewing this. > > On Tue, Jun 12, 2018 at 10:56 PM, Rob Herring wrote: >> On Sat, Jun 02, 2018 at 09:30:10AM +0200, Sergio Paracuellos wrote: >>> Add a devicetree binding documentation for the

Re: [PATCH 2/2] dt-bindings: document gpio-mt7621 bindings

2018-06-13 Thread Sergio Paracuellos
Hi Rob, Thanks for your time in reviewing this. On Tue, Jun 12, 2018 at 10:56 PM, Rob Herring wrote: > On Sat, Jun 02, 2018 at 09:30:10AM +0200, Sergio Paracuellos wrote: >> Add a devicetree binding documentation for the mt7621 driver. > > Bindings are for h/w, not a driver. You are totally

Re: [PATCH 2/2] dt-bindings: document gpio-mt7621 bindings

2018-06-13 Thread Dan Carpenter
On Tue, Jun 12, 2018 at 02:56:38PM -0600, Rob Herring wrote: > Bindings are for h/w, not a driver. > > > Signed-off-by: Sergio Paracuellos > > Reviewed-by: NeilBrown > > Space ^ Pretty sure that was deliberate... Otherwise he's been making that same mistake for over a decade

Re: [PATCH 2/2] dt-bindings: document gpio-mt7621 bindings

2018-06-12 Thread Rob Herring
On Sat, Jun 02, 2018 at 09:30:10AM +0200, Sergio Paracuellos wrote: > Add a devicetree binding documentation for the mt7621 driver. Bindings are for h/w, not a driver. > Signed-off-by: Sergio Paracuellos > Reviewed-by: NeilBrown Space ^ > --- >

[PATCH 2/2] dt-bindings: document gpio-mt7621 bindings

2018-06-02 Thread Sergio Paracuellos
Add a devicetree binding documentation for the mt7621 driver. Signed-off-by: Sergio Paracuellos Reviewed-by: NeilBrown --- .../bindings/gpio/mediatek,mt7621-gpio.txt | 68 ++ 1 file changed, 68 insertions(+) create mode 100644