Re: [PATCH 2/2] staging: vchiq: Remove global bcm*_drvdata

2019-11-13 Thread Stefan Wahren
Hello Marcelo, Am 11.11.19 um 18:14 schrieb Marcelo Diop-Gonzalez: > Moving the DT node check to vchiq_platform_init() > removes the need for these. this comment does match to your changes. Also i'm missing a why this is necessary. > > Signed-off-by: Marcelo Diop-Gonzalez > --- >

Re: [PATCH 2/2] staging: vchiq: Remove global bcm*_drvdata

2019-11-13 Thread Dan Carpenter
On Mon, Nov 11, 2019 at 12:14:24PM -0500, Marcelo Diop-Gonzalez wrote: > @@ -109,7 +108,8 @@ int vchiq_platform_init(struct platform_device *pdev, > struct vchiq_state *state) > if (err < 0) > return err; > > - g_cache_line_size = drvdata->cache_line_size; > + if