[PATCH 3/6] staging: goldfish: document spinlock usage

2014-09-03 Thread Loic Pefferkorn
Coding style: document spinlock usage Signed-off-by: Loic Pefferkorn l...@loicp.eu --- drivers/staging/goldfish/goldfish_audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/goldfish/goldfish_audio.c b/drivers/staging/goldfish/goldfish_audio.c index

Re: [PATCH 3/6] staging: goldfish: document spinlock usage

2014-09-03 Thread One Thousand Gnomes
On Wed, 3 Sep 2014 13:13:44 +0200 Loic Pefferkorn l...@loicp.eu wrote: Coding style: document spinlock usage Signed-off-by: Loic Pefferkorn l...@loicp.eu --- drivers/staging/goldfish/goldfish_audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 3/6] staging: goldfish: document spinlock usage

2014-09-03 Thread Loic Pefferkorn
On Wed, Sep 03, 2014 at 01:13:19PM +0100, One Thousand Gnomes wrote: This tells the reader nothing. It's good to document locking models but - you lock data not code (which is a detail a lot of programmers get wrong in th design stage too) - you need to document