Re: [PATCH 3/7] staging: unisys: cleanup goto in create_visor_device()

2016-02-23 Thread Dan Carpenter
On Tue, Feb 23, 2016 at 11:21:14AM -0500, Ben Romer wrote: > On Tue, 2016-02-23 at 19:16 +0300, Dan Carpenter wrote: > > When you're reviewing, you only have to care about the most recent > > allocation. After this point we need to call put_device(). After > > this > > point we need to call unreg

Re: [PATCH 3/7] staging: unisys: cleanup goto in create_visor_device()

2016-02-23 Thread Ben Romer
On Tue, 2016-02-23 at 19:16 +0300, Dan Carpenter wrote: > When you're reviewing, you only have to care about the most recent > allocation. After this point we need to call put_device(). After > this > point we need to call unregister. The "goto unregister" is pretty > obvious what it does so it

Re: [PATCH 3/7] staging: unisys: cleanup goto in create_visor_device()

2016-02-23 Thread Dan Carpenter
On Tue, Feb 23, 2016 at 10:01:51AM -0500, Benjamin Romer wrote: > Get rid of the rc = -1 initialization, and remove the goto > mess entirely. Return a meaningful error on failure in the function, or > the rc from a called function if it fails. > > Signed-off-by: Benjamin Romer > --- For these ki

[PATCH 3/7] staging: unisys: cleanup goto in create_visor_device()

2016-02-23 Thread Benjamin Romer
Get rid of the rc = -1 initialization, and remove the goto mess entirely. Return a meaningful error on failure in the function, or the rc from a called function if it fails. Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/visorbus_main.c | 18 -- 1 file changed,