From: Jérôme Pouiller <jerome.pouil...@silabs.com>

Original code caused an (100% reproducible) invalid memory access on
big-endian targets.

Fixes: b0998f0c040d "staging: wfx: add IRQ handling"
Reported-by: kbuild test robot <l...@intel.com>
Reported-by: Stephen Rothwell <s...@canb.auug.org.au>
Signed-off-by: Jérôme Pouiller <jerome.pouil...@silabs.com>
---
 drivers/staging/wfx/bh.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/wfx/bh.c b/drivers/staging/wfx/bh.c
index 6000c03bb658..3715bb18bd78 100644
--- a/drivers/staging/wfx/bh.c
+++ b/drivers/staging/wfx/bh.c
@@ -83,12 +83,12 @@ static int rx_helper(struct wfx_dev *wdev, size_t read_len, 
int *is_cnf)
                        // piggyback is probably correct.
                        return piggyback;
                }
-               le16_to_cpus(hif->len);
+               le16_to_cpus(&hif->len);
                computed_len = round_up(hif->len - sizeof(hif->len), 16)
                               + sizeof(struct hif_sl_msg)
                               + sizeof(struct hif_sl_tag);
        } else {
-               le16_to_cpus(hif->len);
+               le16_to_cpus(&hif->len);
                computed_len = round_up(hif->len, 2);
        }
        if (computed_len != read_len) {
-- 
2.20.1
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to