RE: [PATCH 3/8] Drivers: scsi: storvsc: Fix a bug in handling VMBUS protocol version

2014-07-09 Thread KY Srinivasan
t; a...@canonical.com; linux-s...@vger.kernel.org; sta...@vger.kernel.org > Subject: Re: [PATCH 3/8] Drivers: scsi: storvsc: Fix a bug in handling VMBUS > protocol version > > > + if ((vmbus_proto_version == VERSION_WS2008) || > > +(vmbus_proto_version == VERSION_WI

Re: [PATCH 3/8] Drivers: scsi: storvsc: Fix a bug in handling VMBUS protocol version

2014-07-09 Thread Christoph Hellwig
> + if ((vmbus_proto_version == VERSION_WS2008) || > + (vmbus_proto_version == VERSION_WIN7)) { This has superflous braces and doesn't use proper Linux indentation. But I think simply using a switch here might be cleaner anyway. ___ devel

[PATCH 3/8] Drivers: scsi: storvsc: Fix a bug in handling VMBUS protocol version

2014-07-08 Thread K. Y. Srinivasan
Based on the negotiated VMBUS protocol version, we adjust the size of the storage protocol messages. The two sizes we currently handle or pre-win8 and post-win8. Win WS2012 R2, we are negotiating higher VMBUS protocol version than the win8 version. Make adjustments to correctly handle this. Signe