[PATCH 4/6] staging: wilc1000: rework address value.

2015-06-30 Thread Dean Lee
change type to pointer. Signed-off-by: Dean Lee dean@atmel.com --- drivers/staging/wilc1000/host_interface.c | 22 +- drivers/staging/wilc1000/host_interface.h | 4 ++-- 2 files changed, 11 insertions(+), 15 deletions(-) diff --git

Re: [PATCH 4/6] staging: wilc1000: rework address value.

2015-06-30 Thread Dan Carpenter
- if ((pstrHostIfSetDrvHandler-u32Address) == (u32)NULL) { + if (pstrHostIfSetDrvHandler-pAddress == NULL) { In the linux kernel we do not like using 'p' to stand for pointer. This new name uses CamelCase. Use scripts/checkpatch.pl to find obvious mistakes like this. The name address

Re: [PATCH 4/6] staging: wilc1000: rework address value.

2015-06-30 Thread Greg KH
On Tue, Jun 30, 2015 at 05:34:36PM +0900, Dean Lee wrote: change type to pointer. that describes _what_ you did, which is obvious from the patch, but not _why_ you did it. You need to describe this much better before I can take it. One comment on the code: Signed-off-by: Dean Lee