Re: [PATCH 5/8] staging/lustre/osc: extern declare osc_caches in a header

2016-12-07 Thread James Simmons
> This avoids frowned upon extern in the C file, and also > shuts down a sparse warning of > drivers/staging/lustre/lustre/osc/osc_dev.c:55:22: warning: symbol > 'osc_caches' was not declared. Should it be static? Reviewed-by: James Simmons > Signed-off-by: Oleg

Re: [PATCH 5/8] staging/lustre/osc: extern declare osc_caches in a header

2016-12-07 Thread James Simmons
> This avoids frowned upon extern in the C file, and also > shuts down a sparse warning of > drivers/staging/lustre/lustre/osc/osc_dev.c:55:22: warning: symbol > 'osc_caches' was not declared. Should it be static? Reviewed-by: James Simmons > Signed-off-by: Oleg

[PATCH 5/8] staging/lustre/osc: extern declare osc_caches in a header

2016-12-07 Thread Oleg Drokin
This avoids frowned upon extern in the C file, and also shuts down a sparse warning of drivers/staging/lustre/lustre/osc/osc_dev.c:55:22: warning: symbol 'osc_caches' was not declared. Should it be static? Signed-off-by: Oleg Drokin ---