Re: [PATCH 6/7] staging: wfx: drop calls to BUG_ON()

2019-10-08 Thread Dan Carpenter
On Tue, Oct 08, 2019 at 09:43:01AM +, Jerome Pouiller wrote: > @@ -56,9 +56,9 @@ static uint8_t fill_tkip_pair(struct hif_tkip_pairwise_key > *msg, > { > uint8_t *keybuf = key->key; > > - WARN_ON(key->keylen != sizeof(msg->tkip_key_data) > -+ sizeof(msg

[PATCH 6/7] staging: wfx: drop calls to BUG_ON()

2019-10-08 Thread Jerome Pouiller
From: Jérôme Pouiller Most of calls to BUG_ON() could replaced by WARN(). By the way, this patch also try to favor WARN() (that include a comment about the problem) instead of WARN_ON(). Reported-by: Andrew Lunn Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/bh.c | 4 ++-- d