subject:"\[PATCH 6\/8 v3\] staging\: pi433\: use defines for shifting register values"

Re: [PATCH 6/8 v3] staging: pi433: use defines for shifting register values

2017-12-14 Thread Dan Carpenter

You'll need to resend everything. The thread is too messy. On Wed, Dec 13, 2017 at 06:44:44PM +0100, Valentin Vidic wrote: > diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c > index f77ecd60f43a..0889c65d5a31 100644 > --- a/drivers/staging/pi433/rf69.c > +++

Re: [PATCH 6/8 v3] staging: pi433: use defines for shifting register values

2017-12-13 Thread Marcus Wolf

Am 13.12.2017 um 19:44 schrieb Valentin Vidic: Avoid shifting by magic numbers and use defines instead. Signed-off-by: Valentin Vidic --- v2: - drop change for SHIFT_DATAMODUL_MODULATION_TYPE - move shifting to the header file v3: - drop auto case - use

[PATCH 6/8 v3] staging: pi433: use defines for shifting register values

2017-12-13 Thread Valentin Vidic

Avoid shifting by magic numbers and use defines instead. Signed-off-by: Valentin Vidic --- v2: - drop change for SHIFT_DATAMODUL_MODULATION_TYPE - move shifting to the header file v3: - drop auto case - use CURRENT suffix - precompute define values