Re: [PATCH RESEND] staging: rtl8188eu: don't duplicate ieee80211 WLAN_EID_* constants

2015-07-25 Thread Jakub Sitnicki
On Fri, Jul 24, 2015 at 10:39 PM CEST, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Fri, Jul 24, 2015 at 05:12:38PM +0200, Jakub Sitnicki wrote: linux/ieee80211.h already defines constants for information element IDs. Include it where needed, resolve discrepancies in naming, and

Re: [PATCH RESEND] staging: rtl8188eu: don't duplicate ieee80211 WLAN_EID_* constants

2015-07-25 Thread Dan Carpenter
On Sat, Jul 25, 2015 at 04:05:52PM +0200, Jakub Sitnicki wrote: On Fri, Jul 24, 2015 at 10:39 PM CEST, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Fri, Jul 24, 2015 at 05:12:38PM +0200, Jakub Sitnicki wrote: linux/ieee80211.h already defines constants for information element

Re: [PATCH RESEND] staging: rtl8188eu: don't duplicate ieee80211 WLAN_EID_* constants

2015-07-25 Thread Jakub Sitnicki
On Sat, Jul 25, 2015 at 04:30 PM CEST, Dan Carpenter dan.carpen...@oracle.com wrote: On Sat, Jul 25, 2015 at 04:05:52PM +0200, Jakub Sitnicki wrote: On Fri, Jul 24, 2015 at 10:39 PM CEST, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Fri, Jul 24, 2015 at 05:12:38PM +0200, Jakub

[PATCH RESEND] staging: rtl8188eu: don't duplicate ieee80211 WLAN_EID_* constants

2015-07-24 Thread Jakub Sitnicki
linux/ieee80211.h already defines constants for information element IDs. Include it where needed, resolve discrepancies in naming, and remove the duplicated definitions. While at it, wrap a line that was too long and remove extra parentheses in an expression that mixes only equality and logical

Re: [PATCH RESEND] staging: rtl8188eu: don't duplicate ieee80211 WLAN_EID_* constants

2015-07-24 Thread Greg Kroah-Hartman
On Fri, Jul 24, 2015 at 05:12:38PM +0200, Jakub Sitnicki wrote: linux/ieee80211.h already defines constants for information element IDs. Include it where needed, resolve discrepancies in naming, and remove the duplicated definitions. While at it, wrap a line that was too long and remove