On 02/12/2014 03:34 PM, Dan Carpenter wrote:
> Greg mentioned doing the checkpatch.pl fixes later and that applies
> here as well. Leave the LINUX_VERSION_CODE code in for now and delete
> it in a later patch.
>
> On the other hand, I don't want to give you a lot of extra work to do if
> no one e
Greg mentioned doing the checkpatch.pl fixes later and that applies
here as well. Leave the LINUX_VERSION_CODE code in for now and delete
it in a later patch.
On the other hand, I don't want to give you a lot of extra work to do if
no one else cares...
What I'm saying is that when you do moves,
On 02/12/2014 01:39 PM, Greg Kroah-Hartman wrote:
>>
>> diff -urN linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c
>> linux-3.13.1-new/drivers/staging/dgap/dgap_driver.c
>> --- linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c 2014-01-29
>> 08:06:37.0 -0500
>> +++ linux-3.13.1
On Wed, Feb 12, 2014 at 12:44:43PM -0500, Mark Hounschell wrote:
> Merge dgap_fep5.c into dgap_driver.c
>
> Signed-off-by: Mark Hounschell
> Cc: Greg Kroah-Hartman
A good changelog comment doesn't just say what happens, but _why_ it is
happening.
Why are you merging these files?
>
> diff -ur