Re: [PATCH net-next] hv_netvsc: Correct filter setting for multicast/broadcast

2018-03-09 Thread Sergei Shtylyov
On 03/09/2018 09:37 PM, Sergei Shtylyov wrote: >> Commit 009f766 intended to filter multicast/broadcast, however > >At least 12 digits needed here, and the summary line too, just like you do > for the Fixes: tag. > >> the NDIS filter wasn't set properly in non-promiscuous modes, >> which

Re: [PATCH net-next] hv_netvsc: Correct filter setting for multicast/broadcast

2018-03-09 Thread Sergei Shtylyov
Hello! On 03/09/2018 04:25 PM, Mohammed Gamal wrote: > Commit 009f766 intended to filter multicast/broadcast, however At least 12 digits needed here, and the summary line too, just like you do for the Fixes: tag. > the NDIS filter wasn't set properly in non-promiscuous modes, > which

Re: [PATCH net-next] hv_netvsc: Correct filter setting for multicast/broadcast

2018-03-09 Thread David Miller
From: Mohammed Gamal Date: Fri, 9 Mar 2018 12:22:22 +0100 > Commit 009f766 intended to filter multicast/broadcast, however > it did cause DHCP timeouts. A closer look showed that the filters > were not set properly causing this issue. > > Fixes: 009f766 ("hv_netvsc: filter

[PATCH net-next] hv_netvsc: Correct filter setting for multicast/broadcast

2018-03-09 Thread Mohammed Gamal
Commit 009f766 intended to filter multicast/broadcast, however the NDIS filter wasn't set properly in non-promiscuous modes, which resulted in issues like DHCP timeouts. This patch sets the filter flags correctly. Fixes: 009f766 ("hv_netvsc: filter multicast/broadcast") Signed-off-by: Mohammed