Re: [PATCH net-next 10/10] staging: vt6656: inherit addr_assign_type along with dev_addr

2013-08-23 Thread Dan Carpenter
On Fri, Aug 23, 2013 at 02:06:21PM +0200, Bjørn Mork wrote: > Dan Carpenter writes: > > > Ah... Here is the first patch which adds eth_hw_addr_inherit() > > > > http://patchwork.ozlabs.org/patch/269365/ > > > > I don't think we've actually set dst->addr_len yet at this point so > > it doesn't do

Re: [PATCH net-next 10/10] staging: vt6656: inherit addr_assign_type along with dev_addr

2013-08-23 Thread Bjørn Mork
Dan Carpenter writes: > Ah... Here is the first patch which adds eth_hw_addr_inherit() > > http://patchwork.ozlabs.org/patch/269365/ > > I don't think we've actually set dst->addr_len yet at this point so > it doesn't do the memcpy(). This doesn't work. Ouch. Yes, I see. The net_device is all

Re: [PATCH net-next 10/10] staging: vt6656: inherit addr_assign_type along with dev_addr

2013-08-23 Thread Dan Carpenter
Ah... Here is the first patch which adds eth_hw_addr_inherit() http://patchwork.ozlabs.org/patch/269365/ I don't think we've actually set dst->addr_len yet at this point so it doesn't do the memcpy(). This doesn't work. regards, dan carpenter ___ de

Re: [PATCH net-next 10/10] staging: vt6656: inherit addr_assign_type along with dev_addr

2013-08-23 Thread Bjørn Mork
Dan Carpenter writes: > On Fri, Aug 23, 2013 at 11:35:13AM +0200, Bjørn Mork wrote: >> Cc: Forest Bond >> Signed-off-by: Bjørn Mork >> --- > > The changlog is missing. Yes, right. Sorry about that. > Why does this patch help? It ensures that addr_assign_type is set to the same value as the

Re: [PATCH net-next 10/10] staging: vt6656: inherit addr_assign_type along with dev_addr

2013-08-23 Thread Dan Carpenter
On Fri, Aug 23, 2013 at 11:35:13AM +0200, Bjørn Mork wrote: > Cc: Forest Bond > Signed-off-by: Bjørn Mork > --- The changlog is missing. Why does this patch help? regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driv

[PATCH net-next 10/10] staging: vt6656: inherit addr_assign_type along with dev_addr

2013-08-23 Thread Bjørn Mork
Cc: Forest Bond Signed-off-by: Bjørn Mork --- drivers/staging/vt6656/hostap.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/hostap.c b/drivers/staging/vt6656/hostap.c index c699a30..3ddef9d 100644 --- a/drivers/staging/vt6656/hostap.c +++ b/drivers